Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 6770026: Merge 79507 - Before object destruction, make sure that its select dialogs are told that we (Closed)

Created:
9 years, 9 months ago by Chris Evans
Modified:
9 years, 6 months ago
Reviewers:
aarya
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Merge 79507 - Before object destruction, make sure that its select dialogs are told that we are gone so that they don't try and call back to us. This bug was reproducible on extensions, but similar occurences were found in code auditing. BUG=77349 TEST=None Review URL: http://codereview.chromium.org/6747007 TBR=aarya@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79761

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M chrome/browser/extensions/extension_bookmarks_module.cc View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/extensions/extensions_ui.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/certificate_dialogs.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/advanced_options_handler.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_handler.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Chris Evans
9 years, 9 months ago (2011-03-29 23:24:11 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698