Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Side by Side Diff: chrome/browser/extensions/extensions_ui.cc

Issue 6770026: Merge 79507 - Before object destruction, make sure that its select dialogs are told that we (Closed) Base URL: svn://svn.chromium.org/chrome/branches/696/src/
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extensions_ui.h" 5 #include "chrome/browser/extensions/extensions_ui.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/base64.h" 9 #include "base/base64.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 829 matching lines...) Expand 10 before | Expand all | Expand 10 after
840 } else if (!extension->web_extent().ContainsURL(url)) { 840 } else if (!extension->web_extent().ContainsURL(url)) {
841 continue; 841 continue;
842 } 842 }
843 843
844 result->push_back(ExtensionPage(url, process->id(), host->routing_id(), 844 result->push_back(ExtensionPage(url, process->id(), host->routing_id(),
845 process->profile()->IsOffTheRecord())); 845 process->profile()->IsOffTheRecord()));
846 } 846 }
847 } 847 }
848 848
849 ExtensionsDOMHandler::~ExtensionsDOMHandler() { 849 ExtensionsDOMHandler::~ExtensionsDOMHandler() {
850 // There may be pending file dialogs, we need to tell them that we've gone
851 // away so they don't try and call back to us.
852 if (load_extension_dialog_.get())
853 load_extension_dialog_->ListenerDestroyed();
854
850 if (pack_job_.get()) 855 if (pack_job_.get())
851 pack_job_->ClearClient(); 856 pack_job_->ClearClient();
852 857
853 registrar_.RemoveAll(); 858 registrar_.RemoveAll();
854 } 859 }
855 860
856 // ExtensionsDOMHandler, public: ----------------------------------------------- 861 // ExtensionsDOMHandler, public: -----------------------------------------------
857 862
858 ExtensionsUI::ExtensionsUI(TabContents* contents) : WebUI(contents) { 863 ExtensionsUI::ExtensionsUI(TabContents* contents) : WebUI(contents) {
859 ExtensionService *exstension_service = 864 ExtensionService *exstension_service =
(...skipping 12 matching lines...) Expand all
872 // static 877 // static
873 RefCountedMemory* ExtensionsUI::GetFaviconResourceBytes() { 878 RefCountedMemory* ExtensionsUI::GetFaviconResourceBytes() {
874 return ResourceBundle::GetSharedInstance(). 879 return ResourceBundle::GetSharedInstance().
875 LoadDataResourceBytes(IDR_PLUGIN); 880 LoadDataResourceBytes(IDR_PLUGIN);
876 } 881 }
877 882
878 // static 883 // static
879 void ExtensionsUI::RegisterUserPrefs(PrefService* prefs) { 884 void ExtensionsUI::RegisterUserPrefs(PrefService* prefs) {
880 prefs->RegisterBooleanPref(prefs::kExtensionsUIDeveloperMode, false); 885 prefs->RegisterBooleanPref(prefs::kExtensionsUIDeveloperMode, false);
881 } 886 }
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_bookmarks_module.cc ('k') | chrome/browser/ui/gtk/certificate_dialogs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698