Before object destruction, make sure that its select dialogs are told that we

Before object destruction, make sure that its select dialogs are told that we
are gone so that they don't try and call back to us. This bug was reproducible
on extensions, but similar occurences were found in code auditing.

BUG=77349
TEST=None
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79507

[inferno, 2011-03-25 18:45:42]

Brett, can you please review. This is similar to the one you already reviewed
some time back - http://src.chromium.org/viewvc/chrome?view=rev&revision=54763.
I audited remaining places in code, so that this problem goes away forever.
hopefully this is the last incoming security report on this.

[brettw, 2011-03-26 18:12:10]

LGTM

http://codereview.chromium.org/6747007/diff/1/chrome/browser/ui/webui/options...
File chrome/browser/ui/webui/options/certificate_manager_handler.cc (right):

http://codereview.chromium.org/6747007/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/certificate_manager_handler.cc:684: // There may
be pending file dialogs, we need to tell them that we've gone
It's harder for me to follow this with a comment in the middle and no blank
lines. I'd probably add a blank line above this comment and move the module_
clearing above, so the select_file_dialog stuff is grouped together at the
bottom.

[inferno, 2011-03-27 06:05:04]

Thanks Brett. Will move the comment to the bottom before committing.