chrome/browser/extensions/extension_bookmarks_module.cc - Issue 6770026: Merge 79507 - Before object destruction, make sure that its select dialogs are told that we

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_bookmarks_module.cc

Issue 6770026: Merge 79507 - Before object destruction, make sure that its select dialogs are told that we (Closed) Base URL: svn://svn.chromium.org/chrome/branches/696/src/

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_bookmarks_module.cc

===================================================================

--- chrome/browser/extensions/extension_bookmarks_module.cc (revision 79759)

+++ chrome/browser/extensions/extension_bookmarks_module.cc (working copy)

@@ -799,7 +799,12 @@

BookmarksIOFunction::BookmarksIOFunction() {}

-BookmarksIOFunction::~BookmarksIOFunction() {}

+BookmarksIOFunction::~BookmarksIOFunction() {

+ // There may be pending file dialogs, we need to tell them that we've gone

+ // away so they don't try and call back to us.

+ if (select_file_dialog_.get())

+ select_file_dialog_->ListenerDestroyed();

void BookmarksIOFunction::SelectFile(SelectFileDialog::Type type) {

// Balanced in one of the three callbacks of SelectFileDialog:

« no previous file with comments | « no previous file | chrome/browser/extensions/extensions_ui.cc » ('j') | no next file with comments »