Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1498)

Side by Side Diff: chrome/browser/ui/webui/options/advanced_options_handler.cc

Issue 6770026: Merge 79507 - Before object destruction, make sure that its select dialogs are told that we (Closed) Base URL: svn://svn.chromium.org/chrome/branches/696/src/
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/options/advanced_options_handler.h" 5 #include "chrome/browser/ui/webui/options/advanced_options_handler.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 #if (defined(GOOGLE_CHROME_BUILD) && defined(OS_WIN)) || defined(OS_MACOSX) 53 #if (defined(GOOGLE_CHROME_BUILD) && defined(OS_WIN)) || defined(OS_MACOSX)
54 cloud_print_proxy_ui_enabled_ = true; 54 cloud_print_proxy_ui_enabled_ = true;
55 #elif !defined(OS_CHROMEOS) 55 #elif !defined(OS_CHROMEOS)
56 cloud_print_proxy_ui_enabled_ = 56 cloud_print_proxy_ui_enabled_ =
57 CommandLine::ForCurrentProcess()->HasSwitch( 57 CommandLine::ForCurrentProcess()->HasSwitch(
58 switches::kEnableCloudPrintProxy); 58 switches::kEnableCloudPrintProxy);
59 #endif 59 #endif
60 } 60 }
61 61
62 AdvancedOptionsHandler::~AdvancedOptionsHandler() { 62 AdvancedOptionsHandler::~AdvancedOptionsHandler() {
63 // There may be pending file dialogs, we need to tell them that we've gone
64 // away so they don't try and call back to us.
65 if (select_folder_dialog_.get())
66 select_folder_dialog_->ListenerDestroyed();
63 } 67 }
64 68
65 void AdvancedOptionsHandler::GetLocalizedValues( 69 void AdvancedOptionsHandler::GetLocalizedValues(
66 DictionaryValue* localized_strings) { 70 DictionaryValue* localized_strings) {
67 DCHECK(localized_strings); 71 DCHECK(localized_strings);
68 72
69 static OptionsStringResource resources[] = { 73 static OptionsStringResource resources[] = {
70 { "downloadLocationGroupName", 74 { "downloadLocationGroupName",
71 IDS_OPTIONS_DOWNLOADLOCATION_GROUP_NAME }, 75 IDS_OPTIONS_DOWNLOADLOCATION_GROUP_NAME },
72 { "downloadLocationChangeButton", 76 { "downloadLocationChangeButton",
(...skipping 577 matching lines...) Expand 10 before | Expand all | Expand 10 after
650 FundamentalValue useSSL3Value(useSSL3Setting); 654 FundamentalValue useSSL3Value(useSSL3Setting);
651 web_ui_->CallJavascriptFunction( 655 web_ui_->CallJavascriptFunction(
652 L"options.AdvancedOptions.SetUseSSL3CheckboxState", 656 L"options.AdvancedOptions.SetUseSSL3CheckboxState",
653 useSSL3Value, disabledValue); 657 useSSL3Value, disabledValue);
654 FundamentalValue useTLS1Value(useTLS1Setting); 658 FundamentalValue useTLS1Value(useTLS1Setting);
655 web_ui_->CallJavascriptFunction( 659 web_ui_->CallJavascriptFunction(
656 L"options.AdvancedOptions.SetUseTLS1CheckboxState", 660 L"options.AdvancedOptions.SetUseTLS1CheckboxState",
657 useTLS1Value, disabledValue); 661 useTLS1Value, disabledValue);
658 } 662 }
659 #endif 663 #endif
OLDNEW
« no previous file with comments | « chrome/browser/ui/gtk/certificate_dialogs.cc ('k') | chrome/browser/ui/webui/options/certificate_manager_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698