Require an isolate parameter for most external reference creation to

Require an isolate parameter for most external reference creation to
avoid TLS access in connection with external references.

Make the isolate accessible via the assembler.

Only for ia32 at this point. If this looks OK to you I will port it.

R=vitalyr@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=7305

[Vitaly Repeshko, 2011-03-21 17:06:57]

http://codereview.chromium.org/6713074/diff/1/src/assembler.h
File src/assembler.h (right):

http://codereview.chromium.org/6713074/diff/1/src/assembler.h#newcode504
src/assembler.h:504: explicit ExternalReference(Builtins::CFunctionId id,
Isolate* isolate);
I think these should be moved to some class that already has the current isolate
pointer, say, to the Assembler. Otherwise, the code looks too nasty.

http://codereview.chromium.org/6713074/diff/1/src/ia32/builtins-ia32.cc
File src/ia32/builtins-ia32.cc (right):

http://codereview.chromium.org/6713074/diff/1/src/ia32/builtins-ia32.cc#newco...
src/ia32/builtins-ia32.cc:103: __
jmp(Handle<Code>(masm->isolate()->builtins()->builtin(
There's still one more TLS read here for the handle. I think we should introduce
a helper (maybe on Builtins) because this pattern is rather common. Feel free to
do this in a follow up patch.

[Mads Ager (chromium), 2011-03-22 08:42:36]

http://codereview.chromium.org/6713074/diff/1/src/assembler.h
File src/assembler.h (right):

http://codereview.chromium.org/6713074/diff/1/src/assembler.h#newcode504
src/assembler.h:504: explicit ExternalReference(Builtins::CFunctionId id,
Isolate* isolate);
On 2011/03/21 17:06:57, Vitaly Repeshko wrote:
> I think these should be moved to some class that already has the current
isolate
> pointer, say, to the Assembler. Otherwise, the code looks too nasty.

I sort of agree. However, looking into it more, external references are used for
serialization and deserialization where there is no assembler. So the assembler
is not the right place. I could create a ExternalReferenceFactory and have an
instance on the isolate. However, that would not help readability much I think.
It would lead to:

ExternalReferenceFactory* external_reference_factory
    = masm()->isolate()->external_reference_factory();
__ DoStuffWithReference(external_reference_factory->Create(id));

instead of

__ DoStuffWithReference(ExternalReference(id, masm()->isolate()));

And that doesn't help.

I'm open to suggestions, but I don't see a good place for this that would make
the code any more readable.

[Mads Ager (chromium), 2011-03-22 10:44:47]

Ported to other platforms. I'd like to get this in and then iterate when/if we
find a better solution.

[Vitaly Repeshko, 2011-03-22 14:03:53]

LGTM