Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Side by Side Diff: src/x64/assembler-x64.h

Issue 6713074: Require an isolate parameter for most external reference creation to (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Further cleanup Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/serialize.cc ('k') | src/x64/assembler-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 481 matching lines...) Expand 10 before | Expand all | Expand 10 after
492 uint64_t supported_; 492 uint64_t supported_;
493 uint64_t enabled_; 493 uint64_t enabled_;
494 uint64_t found_by_runtime_probing_; 494 uint64_t found_by_runtime_probing_;
495 495
496 friend class Isolate; 496 friend class Isolate;
497 497
498 DISALLOW_COPY_AND_ASSIGN(CpuFeatures); 498 DISALLOW_COPY_AND_ASSIGN(CpuFeatures);
499 }; 499 };
500 500
501 501
502 class Assembler : public Malloced { 502 class Assembler : public AssemblerBase {
503 private: 503 private:
504 // We check before assembling an instruction that there is sufficient 504 // We check before assembling an instruction that there is sufficient
505 // space to write an instruction and its relocation information. 505 // space to write an instruction and its relocation information.
506 // The relocation writer's position must be kGap bytes above the end of 506 // The relocation writer's position must be kGap bytes above the end of
507 // the generated instructions. This leaves enough space for the 507 // the generated instructions. This leaves enough space for the
508 // longest possible x64 instruction, 15 bytes, and the longest possible 508 // longest possible x64 instruction, 15 bytes, and the longest possible
509 // relocation information encoding, RelocInfoWriter::kMaxLength == 16. 509 // relocation information encoding, RelocInfoWriter::kMaxLength == 16.
510 // (There is a 15 byte limit on x64 instruction length that rules out some 510 // (There is a 15 byte limit on x64 instruction length that rules out some
511 // otherwise valid instructions.) 511 // otherwise valid instructions.)
512 // This allows for a single, fast space check per instruction. 512 // This allows for a single, fast space check per instruction.
(...skipping 1094 matching lines...) Expand 10 before | Expand all | Expand 10 after
1607 private: 1607 private:
1608 Assembler* assembler_; 1608 Assembler* assembler_;
1609 #ifdef DEBUG 1609 #ifdef DEBUG
1610 int space_before_; 1610 int space_before_;
1611 #endif 1611 #endif
1612 }; 1612 };
1613 1613
1614 } } // namespace v8::internal 1614 } } // namespace v8::internal
1615 1615
1616 #endif // V8_X64_ASSEMBLER_X64_H_ 1616 #endif // V8_X64_ASSEMBLER_X64_H_
OLDNEW
« no previous file with comments | « src/serialize.cc ('k') | src/x64/assembler-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698