Adding 'isolates' argument to LOG to get rid of multiple TLS fetches in profiling.

Adding 'isolate' argument to LOG macro to get rid of multiple TLS fetches. 

The patch also passes 'isolate' argument to a couple of validation macros/functions in api.cc (IsDeadCheck, ON_BAILOUT), as well as eliminates some redundant isolate tls fetches throughout api.cc (such as uses of HEAP and FACTORY macros)

[Dmitry Lomov, 2011-03-15 23:25:44]

Some notes:

1. ON_BAILOUT and IsDeadCheck macros probably have a bug if API function is
called by external client when current isolate is not set.

2. This is by no means a complete reduction in TLS fetches of isolates. Here are
some of the places from my notes:
* There are redundant TLS fetches in a few macros in api.cc (ENTER_V8,
EXCEPTION_* and others)
* Every "v8::HandleScope scope;" declaration is a TLS fetch, redundant in most
places
* There is a lot of tls fetches in CpuProfile-related classes

I will do another scrub on all these issues once isolates land in bleeding_edge

BUG=
TEST=

[Vitaly Repeshko, 2011-03-16 17:33:24]

Looks good, but some cosmetic cleanup is needed.

Please rebase and fix the errors reported by tools/presubmit.py. (It should also
warn you about lack of space after comma in macro calls.) When reformatting
lines we follow
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Formatting

Thanks,
Vitaly

http://codereview.chromium.org/6696042/diff/1/src/api.cc
File src/api.cc (right):

http://codereview.chromium.org/6696042/diff/1/src/api.cc#newcode386
src/api.cc:386: i::Isolate* isolate = ISOLATE;
Please use i::Isolate::Current() in this file.

http://codereview.chromium.org/6696042/diff/1/src/compiler.cc
File src/compiler.cc (right):

http://codereview.chromium.org/6696042/diff/1/src/compiler.cc#newcode806
src/compiler.cc:806: PROFILE(info->isolate(),
CodeCreateEvent(Logger::ToNativeByScript(tag, *script),
Lines should fit in 80 chars. Please run tools/presubmit.py to catch this and
other style nits.

[Dmitry Lomov, 2011-03-16 22:10:46]

Thanks - rebased and styles issues addressed, new patch uploaded

[Vitaly Repeshko, 2011-03-17 17:02:11]

LGTM. Landed in r7245. Closing code review.


Thanks,
Vitaly