Adding 'isolates' argument to LOG to get rid of multiple TLS fetches in profiling.

src/heap-profiler.cc

 // Copyright 2009-2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 156 matching lines @@
 
 
 // A printer interface implementation for the Retainers profile.
 class RetainersPrinter : public RetainerHeapProfile::Printer {
  public:
   void PrintRetainers(const JSObjectsCluster& cluster,
                       const StringStream& retainers) {
     HeapStringAllocator allocator;
     StringStream stream(&allocator);
     cluster.Print(&stream);
-    LOG(HeapSampleJSRetainersEvent(
+    LOG(ISOLATE,
+        HeapSampleJSRetainersEvent(
         *(stream.ToCString()), *(retainers.ToCString())));
   }
 };
 
 
 // Visitor for printing a cluster tree.
 class ClusterTreePrinter BASE_EMBEDDED {
  public:
   explicit ClusterTreePrinter(StringStream* stream) : stream_(stream) {}
   void Call(const JSObjectsCluster& cluster,
@@ skipping 273 matching lines @@
 ConstructorHeapProfile::ConstructorHeapProfile()
     : zscope_(DELETE_ON_EXIT) {
 }
 
 
 void ConstructorHeapProfile::Call(const JSObjectsCluster& cluster,
                                   const NumberAndSizeInfo& number_and_size) {
   HeapStringAllocator allocator;
   StringStream stream(&allocator);
   cluster.Print(&stream);
-  LOG(HeapSampleJSConstructorEvent(*(stream.ToCString()),
+  LOG(ISOLATE,
+      HeapSampleJSConstructorEvent(*(stream.ToCString()),
                                    number_and_size.number(),
                                    number_and_size.bytes()));
 }
 
 
 void ConstructorHeapProfile::CollectStats(HeapObject* obj) {
   Clusterizer::InsertIntoTree(&js_objects_info_tree_, obj, false);
 }
 
 
@@ skipping 268 matching lines @@
   DeleteArray(static_cast<Address*>(trace));
   object.Dispose();
 }
 
 
 static void PrintProducerStackTrace(Object* obj, void* trace) {
   if (!obj->IsJSObject()) return;
   String* constructor = GetConstructorNameForHeapProfile(JSObject::cast(obj));
   SmartPointer<char> s_name(
       constructor->ToCString(DISALLOW_NULLS, ROBUST_STRING_TRAVERSAL));
-  LOG(HeapSampleJSProducerEvent(GetConstructorName(*s_name),
+  LOG(ISOLATE,
+      HeapSampleJSProducerEvent(GetConstructorName(*s_name),
                                 reinterpret_cast<Address*>(trace)));
 }
 
 
 void HeapProfiler::WriteSample() {
   Isolate* isolate = Isolate::Current();
-  LOG(HeapSampleBeginEvent("Heap", "allocated"));
-  LOG(HeapSampleStats(
-      "Heap", "allocated", HEAP->CommittedMemory(), HEAP->SizeOfObjects()));
+  LOG(isolate, HeapSampleBeginEvent("Heap", "allocated"));
+  LOG(isolate,
+      HeapSampleStats(
+          "Heap", "allocated", HEAP->CommittedMemory(), HEAP->SizeOfObjects()));
 
   AggregatedHeapSnapshot snapshot;
   AggregatedHeapSnapshotGenerator generator(&snapshot);
   generator.GenerateSnapshot();
 
   HistogramInfo* info = snapshot.info();
   for (int i = FIRST_NONSTRING_TYPE;
        i <= AggregatedHeapSnapshotGenerator::kAllStringsType;
        ++i) {
     if (info[i].bytes() > 0) {
-      LOG(HeapSampleItemEvent(info[i].name(), info[i].number(),
+      LOG(isolate,
+          HeapSampleItemEvent(info[i].name(), info[i].number(),
                               info[i].bytes()));
     }
   }
 
   snapshot.js_cons_profile()->PrintStats();
   snapshot.js_retainer_profile()->PrintStats();
 
   isolate->global_handles()->IterateWeakRoots(PrintProducerStackTrace,
                                               StackWeakReferenceCallback);
 
-  LOG(HeapSampleEndEvent("Heap", "allocated"));
+  LOG(isolate, HeapSampleEndEvent("Heap", "allocated"));
 }
 
 
 AggregatedHeapSnapshot::AggregatedHeapSnapshot()
     : info_(NewArray<HistogramInfo>(
         AggregatedHeapSnapshotGenerator::kAllStringsType + 1)) {
 #define DEF_TYPE_NAME(name) info_[name].set_name(#name);
   INSTANCE_TYPE_LIST(DEF_TYPE_NAME);
 #undef DEF_TYPE_NAME
   info_[AggregatedHeapSnapshotGenerator::kAllStringsType].set_name(
@@ skipping 343 matching lines @@
   isolate_->global_handles()->MakeWeak(handle.location(),
                                        static_cast<void*>(stack.start()),
                                        StackWeakReferenceCallback);
 }
 
 
 #endif  // ENABLE_LOGGING_AND_PROFILING
 
 
 } }  // namespace v8::internal