Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: src/ia32/assembler-ia32.cc

Issue 6696042: Adding 'isolates' argument to LOG to get rid of multiple TLS fetches in profiling. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/isolates
Patch Set: Addressing code review feedback + rebase Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/heap-profiler.cc ('k') | src/ia32/regexp-macro-assembler-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 CodeDesc desc; 122 CodeDesc desc;
123 assm.GetCode(&desc); 123 assm.GetCode(&desc);
124 Object* code; 124 Object* code;
125 { MaybeObject* maybe_code = HEAP->CreateCode(desc, 125 { MaybeObject* maybe_code = HEAP->CreateCode(desc,
126 Code::ComputeFlags(Code::STUB), 126 Code::ComputeFlags(Code::STUB),
127 Handle<Code>::null()); 127 Handle<Code>::null());
128 if (!maybe_code->ToObject(&code)) return; 128 if (!maybe_code->ToObject(&code)) return;
129 } 129 }
130 if (!code->IsCode()) return; 130 if (!code->IsCode()) return;
131 131
132 PROFILE(CodeCreateEvent(Logger::BUILTIN_TAG, 132 PROFILE(ISOLATE,
133 CodeCreateEvent(Logger::BUILTIN_TAG,
133 Code::cast(code), "CpuFeatures::Probe")); 134 Code::cast(code), "CpuFeatures::Probe"));
134 typedef uint64_t (*F0)(); 135 typedef uint64_t (*F0)();
135 F0 probe = FUNCTION_CAST<F0>(Code::cast(code)->entry()); 136 F0 probe = FUNCTION_CAST<F0>(Code::cast(code)->entry());
136 supported_ = probe(); 137 supported_ = probe();
137 found_by_runtime_probing_ = supported_; 138 found_by_runtime_probing_ = supported_;
138 uint64_t os_guarantees = OS::CpuFeaturesImpliedByPlatform(); 139 uint64_t os_guarantees = OS::CpuFeaturesImpliedByPlatform();
139 supported_ |= os_guarantees; 140 supported_ |= os_guarantees;
140 found_by_runtime_probing_ &= portable ? ~os_guarantees : 0; 141 found_by_runtime_probing_ &= portable ? ~os_guarantees : 0;
141 } 142 }
142 143
(...skipping 2651 matching lines...) Expand 10 before | Expand all | Expand 10 after
2794 fprintf(coverage_log, "%s\n", file_line); 2795 fprintf(coverage_log, "%s\n", file_line);
2795 fflush(coverage_log); 2796 fflush(coverage_log);
2796 } 2797 }
2797 } 2798 }
2798 2799
2799 #endif 2800 #endif
2800 2801
2801 } } // namespace v8::internal 2802 } } // namespace v8::internal
2802 2803
2803 #endif // V8_TARGET_ARCH_IA32 2804 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/heap-profiler.cc ('k') | src/ia32/regexp-macro-assembler-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698