Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: src/ic.cc

Issue 6696042: Adding 'isolates' argument to LOG to get rid of multiple TLS fetches in profiling. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/isolates
Patch Set: Addressing code review feedback + rebase Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | src/isolate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 928 matching lines...) Expand 10 before | Expand all | Expand 10 after
939 939
940 // Named lookup in the object. 940 // Named lookup in the object.
941 LookupResult lookup; 941 LookupResult lookup;
942 LookupForRead(*object, *name, &lookup); 942 LookupForRead(*object, *name, &lookup);
943 943
944 // If we did not find a property, check if we need to throw an exception. 944 // If we did not find a property, check if we need to throw an exception.
945 if (!lookup.IsProperty()) { 945 if (!lookup.IsProperty()) {
946 if (FLAG_strict || IsContextual(object)) { 946 if (FLAG_strict || IsContextual(object)) {
947 return ReferenceError("not_defined", name); 947 return ReferenceError("not_defined", name);
948 } 948 }
949 LOG(SuspectReadEvent(*name, *object)); 949 LOG(isolate(), SuspectReadEvent(*name, *object));
950 } 950 }
951 951
952 bool can_be_inlined_precheck = 952 bool can_be_inlined_precheck =
953 FLAG_use_ic && 953 FLAG_use_ic &&
954 lookup.IsProperty() && 954 lookup.IsProperty() &&
955 lookup.IsCacheable() && 955 lookup.IsCacheable() &&
956 lookup.holder() == *object && 956 lookup.holder() == *object &&
957 !object->IsAccessCheckNeeded(); 957 !object->IsAccessCheckNeeded();
958 958
959 bool can_be_inlined = 959 bool can_be_inlined =
(...skipping 1416 matching lines...) Expand 10 before | Expand all | Expand 10 after
2376 #undef ADDR 2376 #undef ADDR
2377 }; 2377 };
2378 2378
2379 2379
2380 Address IC::AddressFromUtilityId(IC::UtilityId id) { 2380 Address IC::AddressFromUtilityId(IC::UtilityId id) {
2381 return IC_utilities[id]; 2381 return IC_utilities[id];
2382 } 2382 }
2383 2383
2384 2384
2385 } } // namespace v8::internal 2385 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | src/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698