Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Unified Diff: src/log.h

Issue 6696042: Adding 'isolates' argument to LOG to get rid of multiple TLS fetches in profiling. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/isolates
Patch Set: Addressing code review feedback + rebase Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/jsregexp.cc ('k') | src/log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/log.h
diff --git a/src/log.h b/src/log.h
index 964a593d54d92318418beedc71a93ccd93b7dab7..4fb0e230f0f59d458d910707bebe405736677550 100644
--- a/src/log.h
+++ b/src/log.h
@@ -76,17 +76,16 @@ class SlidingStateWindow;
class LogMessageBuilder;
#undef LOG
-// TODO(isolates): pass isolate pointer here.
#ifdef ENABLE_LOGGING_AND_PROFILING
-#define LOG(Call) \
+#define LOG(isolate, Call) \
do { \
v8::internal::Logger* logger = \
- v8::internal::Isolate::Current()->logger(); \
+ (isolate)->logger(); \
if (logger->is_logging()) \
logger->Call; \
} while (false)
#else
-#define LOG(Call) ((void) 0)
+#define LOG(isolate, Call) ((void) 0)
#endif
#define LOG_EVENTS_AND_TAGS_LIST(V) \
« no previous file with comments | « src/jsregexp.cc ('k') | src/log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698