Remove action_max_timeout_ms and fix all the callers.

Remove action_max_timeout_ms and fix all the callers.

(This was a TODO for phajdan.jr).

BUG=None
TEST=trybots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71861

[tfarina, 2011-01-15 15:07:19]

Please, take a look.

[tfarina, 2011-01-15 15:48:29]

On 2011/01/15 15:07:19, tfarina wrote:
> Please, take a look.

Pawel, do you have any glue how to fix:

http://build.chromium.org/p/tryserver.chromium/builders/win/builds/10965/step...

?

[Paweł Hajdan Jr., 2011-01-17 08:19:32]

+nirnimesh for the pyauto compile issue

I guess that we need to add action_max_timeout_ms somewhere for pyauto, maybe in
PyUITestBase, but maybe in pyautolib, I'm not sure.

LGTM with comments.

http://codereview.chromium.org/6354005/diff/1/chrome/browser/accessibility/ac...
File chrome/browser/accessibility/accessibility_mac_uitest.mm (right):

http://codereview.chromium.org/6354005/diff/1/chrome/browser/accessibility/ac...
chrome/browser/accessibility/accessibility_mac_uitest.mm:45:
TestTimeouts::action_max_timeout_ms()/1000, false);
nit: add spaces around "/"

http://codereview.chromium.org/6354005/diff/1/chrome/test/interactive_ui/mous...
File chrome/test/interactive_ui/mouseleave_interactive_uitest.cc (right):

http://codereview.chromium.org/6354005/diff/1/chrome/test/interactive_ui/mous...
chrome/test/interactive_ui/mouseleave_interactive_uitest.cc:62: const int
timeout_ms = 5 * TestTimeouts::action_max_timeout_ms();
Ouch, this multiplication is bad. Could you find a timeout from TestTimeout that
is roughly 5 times longer than action_max_timeout_ms() and use it instead?

[tfarina, 2011-01-17 12:14:46]

http://codereview.chromium.org/6354005/diff/1/chrome/test/interactive_ui/mous...
File chrome/test/interactive_ui/mouseleave_interactive_uitest.cc (right):

http://codereview.chromium.org/6354005/diff/1/chrome/test/interactive_ui/mous...
chrome/test/interactive_ui/mouseleave_interactive_uitest.cc:62: const int
timeout_ms = 5 * TestTimeouts::action_max_timeout_ms();
On 2011/01/17 08:19:32, Paweł Hajdan Jr. wrote:
> Ouch, this multiplication is bad. Could you find a timeout from TestTimeout
that
> is roughly 5 times longer than action_max_timeout_ms() and use it instead?

The closest is live_operation_timeout_ms(), which is 45000 (but
action_max_timeout_ms is 15000). I will use it instead, unless you are against.

[Paweł Hajdan Jr., 2011-01-17 14:58:03]

http://codereview.chromium.org/6354005/diff/1/chrome/test/interactive_ui/mous...
File chrome/test/interactive_ui/mouseleave_interactive_uitest.cc (right):

http://codereview.chromium.org/6354005/diff/1/chrome/test/interactive_ui/mous...
chrome/test/interactive_ui/mouseleave_interactive_uitest.cc:62: const int
timeout_ms = 5 * TestTimeouts::action_max_timeout_ms();
On 2011/01/17 12:14:46, tfarina wrote:
> On 2011/01/17 08:19:32, Paweł Hajdan Jr. wrote:
> > Ouch, this multiplication is bad. Could you find a timeout from TestTimeout
> that
> > is roughly 5 times longer than action_max_timeout_ms() and use it instead?
> 
> The closest is live_operation_timeout_ms(), which is 45000 (but
> action_max_timeout_ms is 15000). I will use it instead, unless you are
against.

No, live_operation_timeout is meant for code that touches the internet. Let's
use large_test_timeout here. It's three minutes, but should be fine.

[Nirnimesh, 2011-01-18 18:31:17]

You'd need to implement action_max_timeout_ms() in PyUITestBase (in
chrome/test/pyautolib/pyautolib.h/.cc) so that it's available to python.

[tfarina, 2011-01-19 12:30:40]

On 2011/01/18 18:31:17, Nirnimesh wrote:
> You'd need to implement action_max_timeout_ms() in PyUITestBase (in
> chrome/test/pyautolib/pyautolib.h/.cc) so that it's available to python.

Added. PTAL!

http://codereview.chromium.org/6354005/diff/1/chrome/test/interactive_ui/mous...
File chrome/test/interactive_ui/mouseleave_interactive_uitest.cc (right):

http://codereview.chromium.org/6354005/diff/1/chrome/test/interactive_ui/mous...
chrome/test/interactive_ui/mouseleave_interactive_uitest.cc:62: const int
timeout_ms = 5 * TestTimeouts::action_max_timeout_ms();
On 2011/01/17 14:58:03, Paweł Hajdan Jr. wrote:
> On 2011/01/17 12:14:46, tfarina wrote:
> > On 2011/01/17 08:19:32, Paweł Hajdan Jr. wrote:
> > > Ouch, this multiplication is bad. Could you find a timeout from
TestTimeout
> > that
> > > is roughly 5 times longer than action_max_timeout_ms() and use it instead?
> > 
> > The closest is live_operation_timeout_ms(), which is 45000 (but
> > action_max_timeout_ms is 15000). I will use it instead, unless you are
> against.
> 
> No, live_operation_timeout is meant for code that touches the internet. Let's
> use large_test_timeout here. It's three minutes, but should be fine.

Done.

[Paweł Hajdan Jr., 2011-01-19 13:00:03]

LGTM, thanks!

I'm especially happy about removing this 5 * timeout code.

[Nirnimesh, 2011-01-19 20:03:47]

Code I commented on LGTM.