Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4221)

Unified Diff: chrome/browser/dom_ui/bookmarks_ui_uitest.cc

Issue 6354005: Remove action_max_timeout_ms and fix all the callers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/dom_ui/bookmarks_ui_uitest.cc
diff --git a/chrome/browser/dom_ui/bookmarks_ui_uitest.cc b/chrome/browser/dom_ui/bookmarks_ui_uitest.cc
index 6b6ce8b2856374baa7b14b489e1c68861b2c2f3f..04c37f657c7cb2d6917052a397f12cacd87d0722 100644
--- a/chrome/browser/dom_ui/bookmarks_ui_uitest.cc
+++ b/chrome/browser/dom_ui/bookmarks_ui_uitest.cc
@@ -111,7 +111,8 @@ TEST_F(BookmarksUITest, CommandAgainGoesBackToBookmarksTab) {
// Bring up the bookmarks manager tab.
ASSERT_TRUE(browser->RunCommand(IDC_SHOW_BOOKMARK_MANAGER));
- ASSERT_TRUE(browser->WaitForTabToBecomeActive(1, action_max_timeout_ms()));
+ ASSERT_TRUE(browser->WaitForTabToBecomeActive(
+ 1, TestTimeouts::action_max_timeout_ms()));
ASSERT_TRUE(browser->GetTabCount(&tab_count));
ASSERT_EQ(2, tab_count);
@@ -122,11 +123,13 @@ TEST_F(BookmarksUITest, CommandAgainGoesBackToBookmarksTab) {
// Switch to first tab and run command again.
ASSERT_TRUE(browser->ActivateTab(0));
- ASSERT_TRUE(browser->WaitForTabToBecomeActive(0, action_max_timeout_ms()));
+ ASSERT_TRUE(browser->WaitForTabToBecomeActive(
+ 0, TestTimeouts::action_max_timeout_ms()));
ASSERT_TRUE(browser->RunCommand(IDC_SHOW_BOOKMARK_MANAGER));
// Ensure the bookmarks ui tab is active.
- ASSERT_TRUE(browser->WaitForTabToBecomeActive(1, action_max_timeout_ms()));
+ ASSERT_TRUE(browser->WaitForTabToBecomeActive(
+ 1, TestTimeouts::action_max_timeout_ms()));
ASSERT_TRUE(browser->GetTabCount(&tab_count));
ASSERT_EQ(2, tab_count);
}
« no previous file with comments | « chrome/browser/accessibility/accessibility_mac_uitest.mm ('k') | chrome/browser/dom_ui/new_tab_ui_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698