Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Side by Side Diff: chrome/browser/process_singleton_uitest.cc

Issue 6354005: Remove action_max_timeout_ms and fix all the callers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This test validates that the ProcessSingleton class properly makes sure 5 // This test validates that the ProcessSingleton class properly makes sure
6 // that there is only one main browser process. 6 // that there is only one main browser process.
7 // 7 //
8 // It is currently compiled and run on Windows and Posix(non-Mac) platforms. 8 // It is currently compiled and run on Windows and Posix(non-Mac) platforms.
9 // Mac uses system services and ProcessSingletonMac is a noop. (Maybe it still 9 // Mac uses system services and ProcessSingletonMac is a noop. (Maybe it still
10 // makes sense to test that the system services are giving the behavior we 10 // makes sense to test that the system services are giving the behavior we
11 // want?) 11 // want?)
12 12
13 #include <list> 13 #include <list>
14 14
15 #include "base/file_path.h" 15 #include "base/file_path.h"
16 #include "base/file_util.h" 16 #include "base/file_util.h"
17 #include "base/path_service.h" 17 #include "base/path_service.h"
18 #include "base/process_util.h" 18 #include "base/process_util.h"
19 #include "base/ref_counted.h" 19 #include "base/ref_counted.h"
20 #include "base/scoped_temp_dir.h" 20 #include "base/scoped_temp_dir.h"
21 #include "base/threading/thread.h" 21 #include "base/threading/thread.h"
22 #include "base/test/test_timeouts.h"
22 #include "base/synchronization/waitable_event.h" 23 #include "base/synchronization/waitable_event.h"
23 #include "chrome/common/chrome_paths.h" 24 #include "chrome/common/chrome_paths.h"
24 #include "chrome/common/chrome_constants.h" 25 #include "chrome/common/chrome_constants.h"
25 #include "chrome/common/chrome_switches.h" 26 #include "chrome/common/chrome_switches.h"
26 #include "chrome/test/test_launcher_utils.h" 27 #include "chrome/test/test_launcher_utils.h"
27 #include "chrome/test/ui/ui_test.h" 28 #include "chrome/test/ui/ui_test.h"
28 #include "testing/gtest/include/gtest/gtest.h" 29 #include "testing/gtest/include/gtest/gtest.h"
29 30
30 namespace { 31 namespace {
31 32
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 // and thus we must manually reset it for each attempt. 138 // and thus we must manually reset it for each attempt.
138 : threads_waker_(true /* manual */, false /* signaled */) { 139 : threads_waker_(true /* manual */, false /* signaled */) {
139 EXPECT_TRUE(temp_profile_dir_.CreateUniqueTempDir()); 140 EXPECT_TRUE(temp_profile_dir_.CreateUniqueTempDir());
140 } 141 }
141 142
142 void SetUp() { 143 void SetUp() {
143 // Start the threads and create the starters. 144 // Start the threads and create the starters.
144 for (size_t i = 0; i < kNbThreads; ++i) { 145 for (size_t i = 0; i < kNbThreads; ++i) {
145 chrome_starter_threads_[i].reset(new base::Thread("ChromeStarter")); 146 chrome_starter_threads_[i].reset(new base::Thread("ChromeStarter"));
146 ASSERT_TRUE(chrome_starter_threads_[i]->Start()); 147 ASSERT_TRUE(chrome_starter_threads_[i]->Start());
147 chrome_starters_[i] = new ChromeStarter(action_max_timeout_ms(), 148 chrome_starters_[i] = new ChromeStarter(
148 temp_profile_dir_.path()); 149 TestTimeouts::action_max_timeout_ms(), temp_profile_dir_.path());
149 } 150 }
150 } 151 }
151 152
152 void TearDown() { 153 void TearDown() {
153 // Stop the threads. 154 // Stop the threads.
154 for (size_t i = 0; i < kNbThreads; ++i) 155 for (size_t i = 0; i < kNbThreads; ++i)
155 chrome_starter_threads_[i]->Stop(); 156 chrome_starter_threads_[i]->Stop();
156 } 157 }
157 158
158 // This method is used to make sure we kill the main browser process after 159 // This method is used to make sure we kill the main browser process after
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
317 pending_starters.empty(); 318 pending_starters.empty();
318 if (chrome_starters_[last_index]->process_handle_ != 319 if (chrome_starters_[last_index]->process_handle_ !=
319 base::kNullProcessHandle) { 320 base::kNullProcessHandle) {
320 KillProcessTree(chrome_starters_[last_index]->process_handle_); 321 KillProcessTree(chrome_starters_[last_index]->process_handle_);
321 chrome_starters_[last_index]->done_event_.Wait(); 322 chrome_starters_[last_index]->done_event_.Wait();
322 } 323 }
323 } 324 }
324 } 325 }
325 326
326 } // namespace 327 } // namespace
OLDNEW
« no previous file with comments | « chrome/browser/in_process_webkit/dom_storage_uitest.cc ('k') | chrome/browser/sessions/session_restore_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698