Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: chrome/worker/worker_uitest.cc

Issue 6354005: Remove action_max_timeout_ms and fix all the callers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/ui/ui_test.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/worker/worker_uitest.cc
diff --git a/chrome/worker/worker_uitest.cc b/chrome/worker/worker_uitest.cc
index 936f13494ac20c96973a2737780f9d02a439725a..cb83f773ae9c6fed4f4df1f3cb3ea5ff359c26c6 100644
--- a/chrome/worker/worker_uitest.cc
+++ b/chrome/worker/worker_uitest.cc
@@ -48,7 +48,7 @@ class WorkerTest : public UILayoutTest {
ASSERT_TRUE(tab->NavigateToURL(url));
std::string value = WaitUntilCookieNonEmpty(tab.get(), url,
- kTestCompleteCookie, action_max_timeout_ms());
+ kTestCompleteCookie, TestTimeouts::action_max_timeout_ms());
ASSERT_STREQ(kTestCompleteSuccess, value.c_str());
}
@@ -71,7 +71,7 @@ class WorkerTest : public UILayoutTest {
ASSERT_TRUE(tab->NavigateToURL(url));
std::string value = WaitUntilCookieNonEmpty(tab.get(), url,
- kTestCompleteCookie, action_max_timeout_ms());
+ kTestCompleteCookie, TestTimeouts::action_max_timeout_ms());
// Close the incognito window
ASSERT_TRUE(incognito->RunCommand(IDC_CLOSE_WINDOW));
@@ -607,7 +607,7 @@ TEST_F(WorkerTest, FLAKY_WorkerClose) {
FilePath(kWorkerClose));
ASSERT_TRUE(tab->NavigateToURL(url));
std::string value = WaitUntilCookieNonEmpty(tab.get(), url,
- kTestCompleteCookie, action_max_timeout_ms());
+ kTestCompleteCookie, TestTimeouts::action_max_timeout_ms());
ASSERT_STREQ(kTestCompleteSuccess, value.c_str());
ASSERT_TRUE(WaitForProcessCountToBe(1, 0));
}
@@ -624,7 +624,7 @@ TEST_F(WorkerTest, QueuedSharedWorkerShutdown) {
ASSERT_TRUE(tab.get());
ASSERT_TRUE(tab->NavigateToURL(url));
std::string value = WaitUntilCookieNonEmpty(tab.get(), url,
- kTestCompleteCookie, action_max_timeout_ms());
+ kTestCompleteCookie, TestTimeouts::action_max_timeout_ms());
ASSERT_STREQ(kTestCompleteSuccess, value.c_str());
ASSERT_TRUE(WaitForProcessCountToBe(1, max_workers_per_tab));
}
@@ -658,7 +658,7 @@ TEST_F(WorkerTest, FLAKY_MultipleTabsQueuedSharedWorker) {
ASSERT_TRUE(window->AppendTab(url2));
std::string value = WaitUntilCookieNonEmpty(tab.get(), url,
- kTestCompleteCookie, action_max_timeout_ms());
+ kTestCompleteCookie, TestTimeouts::action_max_timeout_ms());
ASSERT_STREQ(kTestCompleteSuccess, value.c_str());
ASSERT_TRUE(WaitForProcessCountToBe(3, max_workers_per_tab));
}
@@ -687,7 +687,7 @@ TEST_F(WorkerTest, FLAKY_QueuedSharedWorkerStartedFromOtherTab) {
ASSERT_TRUE(window->AppendTab(url2));
std::string value = WaitUntilCookieNonEmpty(tab.get(), url,
- kTestCompleteCookie, action_max_timeout_ms());
+ kTestCompleteCookie, TestTimeouts::action_max_timeout_ms());
ASSERT_STREQ(kTestCompleteSuccess, value.c_str());
ASSERT_TRUE(WaitForProcessCountToBe(2, max_workers_per_tab+1));
}
« no previous file with comments | « chrome/test/ui/ui_test.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698