Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: chrome/test/ui/layout_plugin_uitest.cc

Issue 6354005: Remove action_max_timeout_ms and fix all the callers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/test/ui/history_uitest.cc ('k') | chrome/test/ui/npapi_uitest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/ui/ui_test.h" 5 #include "chrome/test/ui/ui_test.h"
6 6
7 #include "base/file_path.h" 7 #include "base/file_path.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "base/test/test_timeouts.h"
9 #include "chrome/common/chrome_paths.h" 10 #include "chrome/common/chrome_paths.h"
10 #include "chrome/common/url_constants.h" 11 #include "chrome/common/url_constants.h"
11 #include "chrome/test/ui_test_utils.h" 12 #include "chrome/test/ui_test_utils.h"
12 #include "chrome/test/automation/tab_proxy.h" 13 #include "chrome/test/automation/tab_proxy.h"
13 #include "chrome/test/ui/npapi_test_helper.h" 14 #include "chrome/test/ui/npapi_test_helper.h"
14 #include "googleurl/src/gurl.h" 15 #include "googleurl/src/gurl.h"
15 #include "net/base/net_util.h" 16 #include "net/base/net_util.h"
16 17
17 using npapi_test::kTestCompleteCookie; 18 using npapi_test::kTestCompleteCookie;
18 using npapi_test::kTestCompleteSuccess; 19 using npapi_test::kTestCompleteSuccess;
(...skipping 26 matching lines...) Expand all
45 46
46 // Tests if a plugin executing a self deleting script using NPN_GetURL 47 // Tests if a plugin executing a self deleting script using NPN_GetURL
47 // works without crashing or hanging 48 // works without crashing or hanging
48 // Flaky: http://crbug.com/59327 49 // Flaky: http://crbug.com/59327
49 TEST_F(LayoutPluginTester, FLAKY_SelfDeletePluginGetUrl) { 50 TEST_F(LayoutPluginTester, FLAKY_SelfDeletePluginGetUrl) {
50 const FilePath test_case(FILE_PATH_LITERAL("self_delete_plugin_geturl.html")); 51 const FilePath test_case(FILE_PATH_LITERAL("self_delete_plugin_geturl.html"));
51 GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case); 52 GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case);
52 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); 53 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url));
53 WaitForFinish("self_delete_plugin_geturl", "1", url, 54 WaitForFinish("self_delete_plugin_geturl", "1", url,
54 kTestCompleteCookie, kTestCompleteSuccess, 55 kTestCompleteCookie, kTestCompleteSuccess,
55 action_max_timeout_ms()); 56 TestTimeouts::action_max_timeout_ms());
56 } 57 }
57 58
58 // Tests if a plugin executing a self deleting script using Invoke 59 // Tests if a plugin executing a self deleting script using Invoke
59 // works without crashing or hanging 60 // works without crashing or hanging
60 // Flaky. See http://crbug.com/30702 61 // Flaky. See http://crbug.com/30702
61 TEST_F(LayoutPluginTester, FLAKY_SelfDeletePluginInvoke) { 62 TEST_F(LayoutPluginTester, FLAKY_SelfDeletePluginInvoke) {
62 const FilePath test_case(FILE_PATH_LITERAL("self_delete_plugin_invoke.html")); 63 const FilePath test_case(FILE_PATH_LITERAL("self_delete_plugin_invoke.html"));
63 GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case); 64 GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case);
64 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); 65 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url));
65 WaitForFinish("self_delete_plugin_invoke", "1", url, 66 WaitForFinish("self_delete_plugin_invoke", "1", url,
66 kTestCompleteCookie, kTestCompleteSuccess, 67 kTestCompleteCookie, kTestCompleteSuccess,
67 action_max_timeout_ms()); 68 TestTimeouts::action_max_timeout_ms());
68 } 69 }
69 70
70 TEST_F(LayoutPluginTester, NPObjectReleasedOnDestruction) { 71 TEST_F(LayoutPluginTester, NPObjectReleasedOnDestruction) {
71 if (ProxyLauncher::in_process_renderer()) 72 if (ProxyLauncher::in_process_renderer())
72 return; 73 return;
73 74
74 const FilePath test_case( 75 const FilePath test_case(
75 FILE_PATH_LITERAL("npobject_released_on_destruction.html")); 76 FILE_PATH_LITERAL("npobject_released_on_destruction.html"));
76 GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case); 77 GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case);
77 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); 78 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url));
(...skipping 10 matching lines...) Expand all
88 // Test that a dialog is properly created when a plugin throws an 89 // Test that a dialog is properly created when a plugin throws an
89 // exception. Should be run for in and out of process plugins, but 90 // exception. Should be run for in and out of process plugins, but
90 // the more interesting case is out of process, where we must route 91 // the more interesting case is out of process, where we must route
91 // the exception to the correct renderer. 92 // the exception to the correct renderer.
92 TEST_F(LayoutPluginTester, NPObjectSetException) { 93 TEST_F(LayoutPluginTester, NPObjectSetException) {
93 const FilePath test_case(FILE_PATH_LITERAL("npobject_set_exception.html")); 94 const FilePath test_case(FILE_PATH_LITERAL("npobject_set_exception.html"));
94 GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case); 95 GURL url = ui_test_utils::GetTestUrl(FilePath(kTestDir), test_case);
95 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url)); 96 ASSERT_NO_FATAL_FAILURE(NavigateToURL(url));
96 WaitForFinish("npobject_set_exception", "1", url, 97 WaitForFinish("npobject_set_exception", "1", url,
97 kTestCompleteCookie, kTestCompleteSuccess, 98 kTestCompleteCookie, kTestCompleteSuccess,
98 action_max_timeout_ms()); 99 TestTimeouts::action_max_timeout_ms());
99 } 100 }
OLDNEW
« no previous file with comments | « chrome/test/ui/history_uitest.cc ('k') | chrome/test/ui/npapi_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698