Fix broken PrefService::preference_set() returning not all registered preferences.

Fix broken PrefService::preference_set() returning not all registered preferences.

This CL allows somebody to ask the PrefService for the effective preference values.

BUG=70809
TEST=prefs.PrefsTest.testUnderTheHoodPref and prefs.PrefsTest.testHomepagePrefs of chrome/test/functional/prefs.py will work again.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72790

[battre, 2011-01-26 16:45:55]

Please review.

[Mattias Nissler (ping if slow), 2011-01-26 17:55:11]

Here you go.

http://codereview.chromium.org/6353015/diff/1/chrome/browser/automation/testi...
File chrome/browser/automation/testing_automation_provider.cc (right):

http://codereview.chromium.org/6353015/diff/1/chrome/browser/automation/testi...
chrome/browser/automation/testing_automation_provider.cc:2795:
profile_->GetPrefs()->GetPreferenceValues(items);
Seems like we could create the DictionaryValue in GetPreferenceValues and just
return it (and ownership).

http://codereview.chromium.org/6353015/diff/1/chrome/browser/prefs/pref_servi...
File chrome/browser/prefs/pref_service.cc (right):

http://codereview.chromium.org/6353015/diff/1/chrome/browser/prefs/pref_servi...
chrome/browser/prefs/pref_service.cc:364: out->Set(i->first, value->DeepCopy());
So here is the problem that Set splits up the path. What do we want here? A way
to avoid that entirely would be to fill in a std::map instead of a
DictionaryValue.

http://codereview.chromium.org/6353015/diff/1/chrome/browser/prefs/pref_servi...
File chrome/browser/prefs/pref_service.h (right):

http://codereview.chromium.org/6353015/diff/1/chrome/browser/prefs/pref_servi...
chrome/browser/prefs/pref_service.h:220: typedef std::set<Preference*,
PreferencePathComparator> PreferenceSet;
Do these declarations still have to be public then?

[Nirnimesh, 2011-01-26 20:55:51]

Edit in PYAUTO_TESTS LGTM. Thanks for fixing.

[battre, 2011-01-27 09:53:27]

Done.

http://codereview.chromium.org/6353015/diff/1/chrome/browser/automation/testi...
File chrome/browser/automation/testing_automation_provider.cc (right):

http://codereview.chromium.org/6353015/diff/1/chrome/browser/automation/testi...
chrome/browser/automation/testing_automation_provider.cc:2795:
profile_->GetPrefs()->GetPreferenceValues(items);
On 2011/01/26 17:55:11, Mattias Nissler wrote:
> Seems like we could create the DictionaryValue in GetPreferenceValues and just
> return it (and ownership).

Done.

http://codereview.chromium.org/6353015/diff/1/chrome/browser/prefs/pref_servi...
File chrome/browser/prefs/pref_service.cc (right):

http://codereview.chromium.org/6353015/diff/1/chrome/browser/prefs/pref_servi...
chrome/browser/prefs/pref_service.cc:364: out->Set(i->first, value->DeepCopy());
On 2011/01/26 17:55:11, Mattias Nissler wrote:
> So here is the problem that Set splits up the path. What do we want here? A
way
> to avoid that entirely would be to fill in a std::map instead of a
> DictionaryValue.

This is what the currently only consumer expects to get.

http://codereview.chromium.org/6353015/diff/1/chrome/browser/prefs/pref_servi...
File chrome/browser/prefs/pref_service.h (right):

http://codereview.chromium.org/6353015/diff/1/chrome/browser/prefs/pref_servi...
chrome/browser/prefs/pref_service.h:220: typedef std::set<Preference*,
PreferencePathComparator> PreferenceSet;
On 2011/01/26 17:55:11, Mattias Nissler wrote:
> Do these declarations still have to be public then?

Done.

[Mattias Nissler (ping if slow), 2011-01-27 12:42:34]

LGTM