Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Side by Side Diff: chrome/browser/prefs/value_map_pref_store.h

Issue 6353015: Fix broken PrefService::preference_set() returning not all registered preferences. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/prefs/pref_service.cc ('k') | chrome/browser/prefs/value_map_pref_store.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PREFS_VALUE_MAP_PREF_STORE_H_ 5 #ifndef CHROME_BROWSER_PREFS_VALUE_MAP_PREF_STORE_H_
6 #define CHROME_BROWSER_PREFS_VALUE_MAP_PREF_STORE_H_ 6 #define CHROME_BROWSER_PREFS_VALUE_MAP_PREF_STORE_H_
7 #pragma once 7 #pragma once
8 8
9 #include <map>
10
11 #include "base/basictypes.h" 9 #include "base/basictypes.h"
12 #include "base/observer_list.h" 10 #include "base/observer_list.h"
13 #include "chrome/browser/prefs/pref_value_map.h" 11 #include "chrome/browser/prefs/pref_value_map.h"
14 #include "chrome/common/pref_store.h" 12 #include "chrome/common/pref_store.h"
15 13
16 // A basic PrefStore implementation that uses a simple name-value map for 14 // A basic PrefStore implementation that uses a simple name-value map for
17 // storing the preference values. 15 // storing the preference values.
18 class ValueMapPrefStore : public PrefStore { 16 class ValueMapPrefStore : public PrefStore {
19 public: 17 public:
18 typedef std::map<std::string, Value*>::iterator iterator;
19 typedef std::map<std::string, Value*>::const_iterator const_iterator;
20
20 ValueMapPrefStore(); 21 ValueMapPrefStore();
21 virtual ~ValueMapPrefStore(); 22 virtual ~ValueMapPrefStore();
22 23
23 // PrefStore overrides: 24 // PrefStore overrides:
24 virtual ReadResult GetValue(const std::string& key, Value** value) const; 25 virtual ReadResult GetValue(const std::string& key, Value** value) const;
25 virtual void AddObserver(PrefStore::Observer* observer); 26 virtual void AddObserver(PrefStore::Observer* observer);
26 virtual void RemoveObserver(PrefStore::Observer* observer); 27 virtual void RemoveObserver(PrefStore::Observer* observer);
27 28
29 iterator begin();
30 iterator end();
31 const_iterator begin() const;
32 const_iterator end() const;
33
28 protected: 34 protected:
29 // Store a |value| for |key| in the store. Also generates an notification if 35 // Store a |value| for |key| in the store. Also generates an notification if
30 // the value changed. Assumes ownership of |value|, which must be non-NULL. 36 // the value changed. Assumes ownership of |value|, which must be non-NULL.
31 void SetValue(const std::string& key, Value* value); 37 void SetValue(const std::string& key, Value* value);
32 38
33 // Remove the value for |key| from the store. Sends a notification if there 39 // Remove the value for |key| from the store. Sends a notification if there
34 // was a value to be removed. 40 // was a value to be removed.
35 void RemoveValue(const std::string& key); 41 void RemoveValue(const std::string& key);
36 42
37 // Notify observers about the initialization completed event. 43 // Notify observers about the initialization completed event.
38 void NotifyInitializationCompleted(); 44 void NotifyInitializationCompleted();
39 45
40 private: 46 private:
41 PrefValueMap prefs_; 47 PrefValueMap prefs_;
42 48
43 ObserverList<PrefStore::Observer, true> observers_; 49 ObserverList<PrefStore::Observer, true> observers_;
44 50
45 DISALLOW_COPY_AND_ASSIGN(ValueMapPrefStore); 51 DISALLOW_COPY_AND_ASSIGN(ValueMapPrefStore);
46 }; 52 };
47 53
48 #endif // CHROME_BROWSER_PREFS_VALUE_MAP_PREF_STORE_H_ 54 #endif // CHROME_BROWSER_PREFS_VALUE_MAP_PREF_STORE_H_
OLDNEW
« no previous file with comments | « chrome/browser/prefs/pref_service.cc ('k') | chrome/browser/prefs/value_map_pref_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698