Fix broken PrefService::preference_set() returning not all registered preferences.

chrome/browser/prefs/pref_service.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This provides a way to access the application's current preferences.
 
 #ifndef CHROME_BROWSER_PREFS_PREF_SERVICE_H_
 #define CHROME_BROWSER_PREFS_PREF_SERVICE_H_
 #pragma once
 
@@ skipping 199 matching lines @@
   // FindPreference returns whether RegisterXXX has been invoked, where as
   // this checks if a value exists for the path.
   bool HasPrefPath(const char* path) const;
 
   class PreferencePathComparator {
    public:
     bool operator() (Preference* lhs, Preference* rhs) const {
       return lhs->name() < rhs->name();
     }
   };
   typedef std::set<Preference*, PreferencePathComparator> PreferenceSet;

[Mattias Nissler (ping if slow), 2011/01/26 17:55:11]

Do these declarations still have to be public then?

[battre, 2011/01/27 09:53:27]

Done.

-  const PreferenceSet& preference_set() const { return prefs_; }
+
+  // Stores the effective preference values in |out|.
+  void GetPreferenceValues(DictionaryValue* out) const;
 
   // A helper method to quickly look up a preference.  Returns NULL if the
   // preference is not registered.
   const Preference* FindPreference(const char* pref_name) const;
 
   bool ReadOnly() const;
 
   // TODO(mnissler): This should not be public. Change client code to call a
   // preference setter or use ScopedPrefUpdate.
   PrefNotifier* pref_notifier() const;
@@ skipping 61 matching lines @@
 
   // Local cache of registered Preference objects. The default_store_
   // is authoritative with respect to what the types and default values
   // of registered preferences are.
   mutable PreferenceSet prefs_;
 
   DISALLOW_COPY_AND_ASSIGN(PrefService);
 };
 
 #endif  // CHROME_BROWSER_PREFS_PREF_SERVICE_H_