Fix broken PrefService::preference_set() returning not all registered preferences.

chrome/browser/automation/testing_automation_provider.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/automation/testing_automation_provider.h"
 
 #include <map>
 #include <string>
 #include <vector>
 
@@ skipping 2773 matching lines @@
     AutomationJSONReply(this, reply_message).SendError(
         StringPrintf("Invalid action: %s", action.c_str()));
   }
 }
 
 // Sample json input: { "command": "GetPrefsInfo" }
 // Refer chrome/test/pyautolib/prefs_info.py for sample json output.
 void TestingAutomationProvider::GetPrefsInfo(Browser* browser,
                                              DictionaryValue* args,
                                              IPC::Message* reply_message) {
-  const PrefService::PreferenceSet& prefs =
-      profile_->GetPrefs()->preference_set();
   DictionaryValue* items = new DictionaryValue;
-  for (PrefService::PreferenceSet::const_iterator it = prefs.begin();
-       it != prefs.end(); ++it) {
-    items->Set((*it)->name(), (*it)->GetValue()->DeepCopy());
-  }
+  profile_->GetPrefs()->GetPreferenceValues(items);

[Mattias Nissler (ping if slow), 2011/01/26 17:55:11]

Seems like we could create the DictionaryValue in GetPreferenceValues and just
return it (and ownership).

[battre, 2011/01/27 09:53:27]

Done.

+
   scoped_ptr<DictionaryValue> return_value(new DictionaryValue);
   return_value->Set("prefs", items);  // return_value owns items.
   AutomationJSONReply(this, reply_message).SendSuccess(return_value.get());
 }
 
 // Sample json input: { "command": "SetPrefs", "path": path, "value": value }
 void TestingAutomationProvider::SetPrefs(Browser* browser,
                                          DictionaryValue* args,
                                          IPC::Message* reply_message) {
   std::string path;
@@ skipping 1703 matching lines @@
     // If you change this, update Observer for NotificationType::SESSION_END
     // below.
     MessageLoop::current()->PostTask(FROM_HERE,
         NewRunnableMethod(this, &TestingAutomationProvider::OnRemoveProvider));
   }
 }
 
 void TestingAutomationProvider::OnRemoveProvider() {
   AutomationProviderList::GetInstance()->RemoveProvider(this);
 }