Fix broken PrefService::preference_set() returning not all registered preferences.

chrome/browser/prefs/pref_service.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prefs/pref_service.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/command_line.h"
@@ skipping 338 matching lines @@
   result = base::SysWideToNativeMB(UTF8ToWide(result));
 #endif
   return FilePath(result);
 }
 
 bool PrefService::HasPrefPath(const char* path) const {
   const Preference* pref = FindPreference(path);
   return pref && !pref->IsDefaultValue();
 }
 
+void PrefService::GetPreferenceValues(DictionaryValue* out) const {
+  DCHECK(CalledOnValidThread());
+  DefaultPrefStore::const_iterator i = default_store_->begin();
+  for (; i != default_store_->end(); ++i) {
+    const Value* value = FindPreference(i->first.c_str())->GetValue();
+    out->Set(i->first, value->DeepCopy());

[Mattias Nissler (ping if slow), 2011/01/26 17:55:11]

So here is the problem that Set splits up the path. What do we want here? A way
to avoid that entirely would be to fill in a std::map instead of a
DictionaryValue.

[battre, 2011/01/27 09:53:27]

This is what the currently only consumer expects to get.

+  }
+}
+
 const PrefService::Preference* PrefService::FindPreference(
     const char* pref_name) const {
   DCHECK(CalledOnValidThread());
   Preference p(this, pref_name, Value::TYPE_NULL);
   PreferenceSet::const_iterator it = prefs_.find(&p);
   if (it != prefs_.end())
     return *it;
   const Value::ValueType type = default_store_->GetType(pref_name);
   if (type == Value::TYPE_NULL)
     return NULL;
@@ skipping 290 matching lines @@
 
 bool PrefService::Preference::IsDefaultValue() const {
   return pref_service_->pref_value_store_->
       PrefValueFromDefaultStore(name_.c_str());
 }
 
 bool PrefService::Preference::IsUserModifiable() const {
   return pref_service_->pref_value_store_->
       PrefValueUserModifiable(name_.c_str());
 }