Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 6279003: Move ppapi audio interface out of dev, but... (Closed)

Created:
9 years, 11 months ago by nfullagar
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Move ppapi audio interface out of dev, but for this CL, also keep the old dev interface around temporarily, to avoid tree breakage. Add sample_rate to RecommendSampleFrameCount() to the non-dev audio interface. Currently ignored, but useful information to use when we need to refine RecommendSampleFrameCount() Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71527

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Patch Set 11 : '' #

Patch Set 12 : '' #

Patch Set 13 : '' #

Patch Set 14 : '' #

Patch Set 15 : '' #

Patch Set 16 : '' #

Patch Set 17 : '' #

Patch Set 18 : '' #

Patch Set 19 : '' #

Patch Set 20 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+500 lines, -71 lines) Patch
A ppapi/c/ppb_audio.h View 1 2 1 chunk +73 lines, -0 lines 0 comments Download
A ppapi/c/ppb_audio_config.h View 1 2 1 chunk +98 lines, -0 lines 0 comments Download
A ppapi/c/trusted/ppb_audio_trusted.h View 1 2 1 chunk +50 lines, -0 lines 0 comments Download
A ppapi/cpp/audio.h View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
A ppapi/cpp/audio.cc View 1 2 1 chunk +41 lines, -0 lines 0 comments Download
A ppapi/cpp/audio_config.h View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
A ppapi/cpp/audio_config.cc View 1 2 1 chunk +49 lines, -0 lines 0 comments Download
M ppapi/cpp/dev/audio_config_dev.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +1 line, -1 line 0 comments Download
M ppapi/examples/audio/audio.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 4 chunks +11 lines, -9 lines 0 comments Download
M ppapi/ppapi.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 3 chunks +7 lines, -0 lines 0 comments Download
M ppapi/proxy/dispatcher.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 3 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/ppapi_messages_internal.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/proxy/ppb_audio_config_proxy.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 3 chunks +6 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_audio_config_proxy.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 8 chunks +17 lines, -13 lines 0 comments Download
M ppapi/proxy/ppb_audio_proxy.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/ppb_audio_proxy.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 4 chunks +9 lines, -9 lines 0 comments Download
M ppapi/shared_impl/audio_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppb_audio_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 3 chunks +9 lines, -9 lines 0 comments Download
M webkit/plugins/ppapi/ppb_audio_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 10 chunks +18 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nfullagar
9 years, 11 months ago (2011-01-14 21:16:38 UTC) #1
brettw
LGTM
9 years, 11 months ago (2011-01-14 22:11:14 UTC) #2
nfullagar
9 years, 11 months ago (2011-01-15 01:06:02 UTC) #3
thx, committed as r71527

Powered by Google App Engine
This is Rietveld 408576698