Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: webkit/plugins/ppapi/ppb_audio_impl.cc

Issue 6279003: Move ppapi audio interface out of dev, but... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/plugins/ppapi/ppb_audio_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/ppb_audio_impl.cc
===================================================================
--- webkit/plugins/ppapi/ppb_audio_impl.cc (revision 71486)
+++ webkit/plugins/ppapi/ppb_audio_impl.cc (working copy)
@@ -5,9 +5,10 @@
#include "webkit/plugins/ppapi/ppb_audio_impl.h"
#include "base/logging.h"
-#include "ppapi/c/dev/ppb_audio_dev.h"
-#include "ppapi/c/dev/ppb_audio_trusted_dev.h"
#include "ppapi/c/pp_completion_callback.h"
+#include "ppapi/c/ppb_audio.h"
+#include "ppapi/c/ppb_audio_config.h"
+#include "ppapi/c/trusted/ppb_audio_trusted.h"
#include "webkit/plugins/ppapi/common.h"
namespace webkit {
@@ -17,10 +18,11 @@
// PPB_AudioConfig -------------------------------------------------------------
-uint32_t RecommendSampleFrameCount(uint32_t requested_sample_frame_count);
+uint32_t RecommendSampleFrameCount(PP_AudioSampleRate sample_rate,
+ uint32_t requested_sample_frame_count);
PP_Resource CreateStereo16bit(PP_Instance instance_id,
- PP_AudioSampleRate_Dev sample_rate,
+ PP_AudioSampleRate sample_rate,
uint32_t sample_frame_count) {
PluginInstance* instance = ResourceTracker::Get()->GetInstance(instance_id);
if (!instance)
@@ -34,7 +36,8 @@
// TODO(brettw): Currently we don't actually query to get a value from the
// hardware, so just validate the range.
- if (RecommendSampleFrameCount(sample_frame_count) != sample_frame_count)
+ if (RecommendSampleFrameCount(sample_rate, sample_frame_count) !=
+ sample_frame_count)
return 0;
scoped_refptr<PPB_AudioConfig_Impl> config(
@@ -43,7 +46,8 @@
return config->GetReference();
}
-uint32_t RecommendSampleFrameCount(uint32_t requested_sample_frame_count) {
+uint32_t RecommendSampleFrameCount(PP_AudioSampleRate sample_rate,
+ uint32_t requested_sample_frame_count) {
// TODO(brettw) Currently we don't actually query to get a value from the
// hardware, so we always return the input for in-range values.
if (requested_sample_frame_count < PP_AUDIOMINSAMPLEFRAMECOUNT)
@@ -59,7 +63,7 @@
return BoolToPPBool(!!config);
}
-PP_AudioSampleRate_Dev GetSampleRate(PP_Resource config_id) {
+PP_AudioSampleRate GetSampleRate(PP_Resource config_id) {
scoped_refptr<PPB_AudioConfig_Impl> config =
Resource::GetAs<PPB_AudioConfig_Impl>(config_id);
return config ? config->sample_rate() : PP_AUDIOSAMPLERATE_NONE;
@@ -71,7 +75,7 @@
return config ? config->sample_frame_count() : 0;
}
-const PPB_AudioConfig_Dev ppb_audioconfig = {
+const PPB_AudioConfig ppb_audioconfig = {
&CreateStereo16bit,
&RecommendSampleFrameCount,
&IsAudioConfig,
@@ -120,7 +124,7 @@
return audio ? BoolToPPBool(audio->StopPlayback()) : PP_FALSE;
}
-const PPB_Audio_Dev ppb_audio = {
+const PPB_Audio ppb_audio = {
&Create,
&IsAudio,
&GetCurrentConfig,
@@ -173,7 +177,7 @@
return PP_ERROR_BADRESOURCE;
}
-const PPB_AudioTrusted_Dev ppb_audiotrusted = {
+const PPB_AudioTrusted ppb_audiotrusted = {
&CreateTrusted,
&Open,
&GetSyncSocket,
@@ -186,14 +190,14 @@
PPB_AudioConfig_Impl::PPB_AudioConfig_Impl(
PluginModule* module,
- PP_AudioSampleRate_Dev sample_rate,
+ PP_AudioSampleRate sample_rate,
uint32_t sample_frame_count)
: Resource(module),
sample_rate_(sample_rate),
sample_frame_count_(sample_frame_count) {
}
-const PPB_AudioConfig_Dev* PPB_AudioConfig_Impl::GetInterface() {
+const PPB_AudioConfig* PPB_AudioConfig_Impl::GetInterface() {
return &ppb_audioconfig;
}
@@ -234,11 +238,11 @@
}
}
-const PPB_Audio_Dev* PPB_Audio_Impl::GetInterface() {
+const PPB_Audio* PPB_Audio_Impl::GetInterface() {
return &ppb_audio;
}
-const PPB_AudioTrusted_Dev* PPB_Audio_Impl::GetTrustedInterface() {
+const PPB_AudioTrusted* PPB_Audio_Impl::GetTrustedInterface() {
return &ppb_audiotrusted;
}
« no previous file with comments | « webkit/plugins/ppapi/ppb_audio_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698