Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6248026: Rename Real* to Double* in values.* and dependent files (Closed)

Created:
9 years, 11 months ago by arv (Not doing code reviews)
Modified:
9 years, 4 months ago
Reviewers:
tony
CC:
chromium-reviews, vrk (LEFT CHROMIUM), cbentzel+watch_chromium.org, sjl, Alpha Left Google, ddorwin+watch_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, jam, Aaron Boodman, acolwell GONE FROM CHROMIUM, annacc, pam+watch_chromium.org, awong, Paweł Hajdan Jr., darin-cc_chromium.org, scherkus (not reviewing), Ilya Sherman, dhollowa, arv (Not doing code reviews), James Hawkins, ceee-reviews_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Rename Real* to Double* in values.* and dependent files BUG=None TEST=Compiles and passes all tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73232

Patch Set 1 #

Patch Set 2 : More renames #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -359 lines) Patch
M base/json/json_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/json/json_reader_unittest.cc View 1 2 chunks +36 lines, -36 lines 0 comments Download
M base/json/json_writer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/json/json_writer_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M base/values.h View 9 chunks +9 lines, -9 lines 0 comments Download
M base/values.cc View 10 chunks +21 lines, -21 lines 0 comments Download
M base/values_unittest.cc View 1 10 chunks +19 lines, -19 lines 0 comments Download
M ceee/ie/broker/cookie_api_module.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ceee/ie/broker/tab_api_module_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ceee/ie/broker/window_events_funnel_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ceee/ie/plugin/bho/events_funnel_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ceee/ie/plugin/bho/webnavigation_events_funnel.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M ceee/ie/plugin/bho/webnavigation_events_funnel_unittest.cc View 1 6 chunks +12 lines, -12 lines 0 comments Download
M ceee/ie/plugin/bho/webrequest_events_funnel.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M ceee/ie/plugin/bho/webrequest_events_funnel_unittest.cc View 1 6 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/autofill/autofill_download.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/autofill/autofill_manager.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/audio_mixer_alsa.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/audio_mixer_alsa.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros_settings.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/cros_settings.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/dom_ui/foreign_session_handler.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/dom_ui/ntp_resource_cache.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/dom_ui/options/core_options_handler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/options/core_options_handler.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/dom_ui/shown_sections_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/value_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_bookmark_helpers.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_cookies_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_cookies_helpers.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_cookies_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_history_api.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_processes_api.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_tts_api_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_webnavigation_api.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/geolocation/network_location_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/host_zoom_map.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/host_zoom_map_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/net/predictor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/referrer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/device_management_policy_cache.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/device_management_policy_cache_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/prefs/pref_member.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/prefs/pref_member.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/prefs/pref_member_unittest.cc View 1 4 chunks +22 lines, -22 lines 0 comments Download
M chrome/browser/prefs/pref_service.h View 1 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/prefs/pref_service.cc View 1 6 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 1 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/renderer_host/test/render_view_host_browsertest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/pref_ui.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/preferences.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/speech/speech_recognition_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/themes/browser_theme_pack.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/web_resource/web_resource_service.cc View 1 6 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/web_resource/web_resource_service_unittest.cc View 1 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/common/common_param_traits_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/json_schema_validator.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/json_schema_validator_unittest_base.cc View 5 chunks +16 lines, -16 lines 0 comments Download
M chrome/common/json_value_serializer_unittest.cc View 1 chunk +1 line, -1 line 2 comments Download
M chrome/renderer/dom_ui_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/renderer_extension_bindings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/automation/browser_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/webdriver/utility_functions.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_message_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/ipc_message_utils.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/base/media_format.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/transport_security_state.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
arv (Not doing code reviews)
http://codereview.chromium.org/6248026/diff/2001/chrome/common/json_value_serializer_unittest.cc File chrome/common/json_value_serializer_unittest.cc (right): http://codereview.chromium.org/6248026/diff/2001/chrome/common/json_value_serializer_unittest.cc#newcode42 chrome/common/json_value_serializer_unittest.cc:42: ASSERT_TRUE(root_dict->GetDouble("real", &real_value)); Renamed string locally
9 years, 10 months ago (2011-01-31 22:54:12 UTC) #1
tony
9 years, 10 months ago (2011-01-31 23:00:12 UTC) #2 
Rubber stamp LGTM.  I looked through the changes in base/* and
chrome/browser/prefs/* and they looked fine.

http://codereview.chromium.org/6248026/diff/2001/chrome/common/json_value_ser...
File chrome/common/json_value_serializer_unittest.cc (right):

http://codereview.chromium.org/6248026/diff/2001/chrome/common/json_value_ser...
chrome/common/json_value_serializer_unittest.cc:42:
ASSERT_TRUE(root_dict->GetDouble("real", &real_value));
On 2011/01/31 22:54:13, arv wrote:
> Renamed string locally

OK.

Powered by Google App Engine
This is Rietveld 408576698