Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2403)

Unified Diff: chrome/browser/extensions/extension_history_api.cc

Issue 6248026: Rename Real* to Double* in values.* and dependent files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More renames Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_history_api.cc
diff --git a/chrome/browser/extensions/extension_history_api.cc b/chrome/browser/extensions/extension_history_api.cc
index 5ff98e3b5741cd1f4794324a153b2b2df3c037ce..65bef38529636ac2e4c441381b6ef1ab6e51b9a0 100644
--- a/chrome/browser/extensions/extension_history_api.cc
+++ b/chrome/browser/extensions/extension_history_api.cc
@@ -31,7 +31,8 @@ void GetHistoryItemDictionary(const history::URLRow& row,
value->SetString(keys::kIdKey, base::Int64ToString(row.id()));
value->SetString(keys::kUrlKey, row.url().spec());
value->SetString(keys::kTitleKey, row.title());
- value->SetReal(keys::kLastVisitdKey, MilliSecondsFromTime(row.last_visit()));
+ value->SetDouble(keys::kLastVisitdKey,
+ MilliSecondsFromTime(row.last_visit()));
value->SetInteger(keys::kTypedCountKey, row.typed_count());
value->SetInteger(keys::kVisitCountKey, row.visit_count());
}
@@ -46,7 +47,7 @@ void GetVisitInfoDictionary(const history::VisitRow& row,
DictionaryValue* value) {
value->SetString(keys::kIdKey, base::Int64ToString(row.url_id));
value->SetString(keys::kVisitId, base::Int64ToString(row.visit_id));
- value->SetReal(keys::kVisitTime, MilliSecondsFromTime(row.visit_time));
+ value->SetDouble(keys::kVisitTime, MilliSecondsFromTime(row.visit_time));
value->SetString(keys::kReferringVisitId,
base::Int64ToString(row.referring_visit));
@@ -175,7 +176,7 @@ bool HistoryFunction::GetUrlFromValue(Value* value, GURL* url) {
bool HistoryFunction::GetTimeFromValue(Value* value, base::Time* time) {
double ms_from_epoch = 0.0;
- if (!value->GetAsReal(&ms_from_epoch)) {
+ if (!value->GetAsDouble(&ms_from_epoch)) {
int ms_from_epoch_as_int = 0;
if (!value->GetAsInteger(&ms_from_epoch_as_int))
return false;

Powered by Google App Engine
This is Rietveld 408576698