Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 6015011: Use the macro assembler Set instead of explicit xor for clearing registers. (Closed)

Created:
9 years, 11 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Use the macro assembler Set instead of explicit xor for clearing registers. Committed: http://code.google.com/p/v8/source/detail?r=6135

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -28 lines) Patch
M src/ia32/builtins-ia32.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/ia32/debug-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/ic-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/regexp-macro-assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/builtins-x64.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/x64/debug-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/regexp-macro-assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
9 years, 11 months ago (2011-01-03 11:11:51 UTC) #1
Lasse Reichstein
9 years, 11 months ago (2011-01-03 11:31:06 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698