Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: src/x64/regexp-macro-assembler-x64.cc

Issue 6015011: Use the macro assembler Set instead of explicit xor for clearing registers. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/macro-assembler-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 670 matching lines...) Expand 10 before | Expand all | Expand 10 after
681 return true; 681 return true;
682 // No custom implementation (yet): s(UC16), S(UC16). 682 // No custom implementation (yet): s(UC16), S(UC16).
683 default: 683 default:
684 return false; 684 return false;
685 } 685 }
686 } 686 }
687 687
688 688
689 void RegExpMacroAssemblerX64::Fail() { 689 void RegExpMacroAssemblerX64::Fail() {
690 ASSERT(FAILURE == 0); // Return value for failure is zero. 690 ASSERT(FAILURE == 0); // Return value for failure is zero.
691 __ xor_(rax, rax); // zero rax. 691 __ Set(rax, 0);
692 __ jmp(&exit_label_); 692 __ jmp(&exit_label_);
693 } 693 }
694 694
695 695
696 Handle<Object> RegExpMacroAssemblerX64::GetCode(Handle<String> source) { 696 Handle<Object> RegExpMacroAssemblerX64::GetCode(Handle<String> source) {
697 // Finalize code - write the entry point code now we know how many 697 // Finalize code - write the entry point code now we know how many
698 // registers we need. 698 // registers we need.
699 // Entry code: 699 // Entry code:
700 __ bind(&entry_label_); 700 __ bind(&entry_label_);
701 // Start new stack frame. 701 // Start new stack frame.
(...skipping 671 matching lines...) Expand 10 before | Expand all | Expand 10 after
1373 } 1373 }
1374 } 1374 }
1375 1375
1376 #undef __ 1376 #undef __
1377 1377
1378 #endif // V8_INTERPRETED_REGEXP 1378 #endif // V8_INTERPRETED_REGEXP
1379 1379
1380 }} // namespace v8::internal 1380 }} // namespace v8::internal
1381 1381
1382 #endif // V8_TARGET_ARCH_X64 1382 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/macro-assembler-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698