Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/ia32/ic-ia32.cc

Issue 6015011: Use the macro assembler Set instead of explicit xor for clearing registers. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/debug-ia32.cc ('k') | src/ia32/regexp-macro-assembler-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1181 matching lines...) Expand 10 before | Expand all | Expand 10 after
1192 __ bind(&is_nan); 1192 __ bind(&is_nan);
1193 __ ffree(); 1193 __ ffree();
1194 __ fincstp(); 1194 __ fincstp();
1195 switch (array_type) { 1195 switch (array_type) {
1196 case kExternalByteArray: 1196 case kExternalByteArray:
1197 case kExternalUnsignedByteArray: 1197 case kExternalUnsignedByteArray:
1198 __ mov_b(Operand(edi, ebx, times_1, 0), 0); 1198 __ mov_b(Operand(edi, ebx, times_1, 0), 0);
1199 break; 1199 break;
1200 case kExternalShortArray: 1200 case kExternalShortArray:
1201 case kExternalUnsignedShortArray: 1201 case kExternalUnsignedShortArray:
1202 __ xor_(ecx, Operand(ecx)); 1202 __ Set(ecx, Immediate(0));
1203 __ mov_w(Operand(edi, ebx, times_2, 0), ecx); 1203 __ mov_w(Operand(edi, ebx, times_2, 0), ecx);
1204 break; 1204 break;
1205 case kExternalIntArray: 1205 case kExternalIntArray:
1206 case kExternalUnsignedIntArray: 1206 case kExternalUnsignedIntArray:
1207 __ mov(Operand(edi, ebx, times_4, 0), Immediate(0)); 1207 __ mov(Operand(edi, ebx, times_4, 0), Immediate(0));
1208 break; 1208 break;
1209 default: 1209 default:
1210 UNREACHABLE(); 1210 UNREACHABLE();
1211 break; 1211 break;
1212 } 1212 }
(...skipping 907 matching lines...) Expand 10 before | Expand all | Expand 10 after
2120 Condition cc = *jmp_address == Assembler::kJncShortOpcode 2120 Condition cc = *jmp_address == Assembler::kJncShortOpcode
2121 ? not_zero 2121 ? not_zero
2122 : zero; 2122 : zero;
2123 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 2123 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
2124 } 2124 }
2125 2125
2126 2126
2127 } } // namespace v8::internal 2127 } } // namespace v8::internal
2128 2128
2129 #endif // V8_TARGET_ARCH_IA32 2129 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/debug-ia32.cc ('k') | src/ia32/regexp-macro-assembler-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698