Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: src/ia32/debug-ia32.cc

Issue 6015011: Use the macro assembler Set instead of explicit xor for clearing registers. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/ic-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 __ Assert(zero, "Unable to encode value as smi"); 118 __ Assert(zero, "Unable to encode value as smi");
119 } 119 }
120 __ SmiTag(reg); 120 __ SmiTag(reg);
121 __ push(reg); 121 __ push(reg);
122 } 122 }
123 } 123 }
124 124
125 #ifdef DEBUG 125 #ifdef DEBUG
126 __ RecordComment("// Calling from debug break to runtime - come in - over"); 126 __ RecordComment("// Calling from debug break to runtime - come in - over");
127 #endif 127 #endif
128 __ Set(eax, Immediate(0)); // no arguments 128 __ Set(eax, Immediate(0)); // No arguments.
129 __ mov(ebx, Immediate(ExternalReference::debug_break())); 129 __ mov(ebx, Immediate(ExternalReference::debug_break()));
130 130
131 CEntryStub ceb(1); 131 CEntryStub ceb(1);
132 __ CallStub(&ceb); 132 __ CallStub(&ceb);
133 133
134 // Restore the register values containing object pointers from the expression 134 // Restore the register values containing object pointers from the expression
135 // stack. 135 // stack.
136 for (int i = kNumJSCallerSaved; --i >= 0;) { 136 for (int i = kNumJSCallerSaved; --i >= 0;) {
137 int r = JSCallerSavedCode(i); 137 int r = JSCallerSavedCode(i);
138 Register reg = { r }; 138 Register reg = { r };
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
300 300
301 const bool Debug::kFrameDropperSupported = true; 301 const bool Debug::kFrameDropperSupported = true;
302 302
303 #undef __ 303 #undef __
304 304
305 #endif // ENABLE_DEBUGGER_SUPPORT 305 #endif // ENABLE_DEBUGGER_SUPPORT
306 306
307 } } // namespace v8::internal 307 } } // namespace v8::internal
308 308
309 #endif // V8_TARGET_ARCH_IA32 309 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/ic-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698