Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: src/ia32/regexp-macro-assembler-ia32.cc

Issue 6015011: Use the macro assembler Set instead of explicit xor for clearing registers. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | src/x64/assembler-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2008-2009 the V8 project authors. All rights reserved. 1 // Copyright 2008-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 634 matching lines...) Expand 10 before | Expand all | Expand 10 after
645 } 645 }
646 // No custom implementation (yet): s(UC16), S(UC16). 646 // No custom implementation (yet): s(UC16), S(UC16).
647 default: 647 default:
648 return false; 648 return false;
649 } 649 }
650 } 650 }
651 651
652 652
653 void RegExpMacroAssemblerIA32::Fail() { 653 void RegExpMacroAssemblerIA32::Fail() {
654 ASSERT(FAILURE == 0); // Return value for failure is zero. 654 ASSERT(FAILURE == 0); // Return value for failure is zero.
655 __ xor_(eax, Operand(eax)); // zero eax. 655 __ Set(eax, Immediate(0));
656 __ jmp(&exit_label_); 656 __ jmp(&exit_label_);
657 } 657 }
658 658
659 659
660 Handle<Object> RegExpMacroAssemblerIA32::GetCode(Handle<String> source) { 660 Handle<Object> RegExpMacroAssemblerIA32::GetCode(Handle<String> source) {
661 // Finalize code - write the entry point code now we know how many 661 // Finalize code - write the entry point code now we know how many
662 // registers we need. 662 // registers we need.
663 663
664 // Entry code: 664 // Entry code:
665 __ bind(&entry_label_); 665 __ bind(&entry_label_);
(...skipping 578 matching lines...) Expand 10 before | Expand all | Expand 10 after
1244 } 1244 }
1245 1245
1246 1246
1247 #undef __ 1247 #undef __
1248 1248
1249 #endif // V8_INTERPRETED_REGEXP 1249 #endif // V8_INTERPRETED_REGEXP
1250 1250
1251 }} // namespace v8::internal 1251 }} // namespace v8::internal
1252 1252
1253 #endif // V8_TARGET_ARCH_IA32 1253 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | src/x64/assembler-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698