Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 4974001: base: Get rid of 'using' declaration of StringAppendF. (Closed)

Created:
10 years, 1 month ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, michaeln, cbentzel+watch_chromium.org, stuartmorgan+watch_chromium.org, ben+cc_chromium.org, amit, brettw-cc_chromium.org, jam, darin-cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

base: Get rid of 'using' declaration of StringAppendF. Update the callers to append base:: in the calls to StringAppendF. BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66116

Patch Set 1 : #

Total comments: 4

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -123 lines) Patch
M base/stringprintf.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/crash_handler_host_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/history/text_database.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/metrics_log_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/predictor.cc View 1 chunk +9 lines, -7 lines 0 comments Download
M chrome/browser/net/url_info.cc View 3 chunks +16 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/common/sandbox_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/net/service_url_request_context.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/test/automation/automation_proxy_uitest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/test/startup/feature_startup_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/startup/shutdown_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/startup/startup_test.cc View 4 chunks +9 lines, -6 lines 0 comments Download
M chrome/test/tab_switching/tab_switching_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/perf/chrome_frame_perftest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M courgette/adjustment_method.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M courgette/adjustment_method_2.cc View 8 chunks +21 lines, -20 lines 0 comments Download
M courgette/memory_monitor.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M net/http/http_cache_unittest.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M net/http/http_request_headers.cc View 1 1 chunk +6 lines, -4 lines 0 comments Download
M net/http/http_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_bypass_rules.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/flip_server/balsa_headers.cc View 1 chunk +9 lines, -8 lines 0 comments Download
M net/tools/hresolv/hresolv.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M net/url_request/url_request_job_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/view_cache_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/appcache/view_appcache_internals_job.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/blob/view_blob_internals_job.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M webkit/glue/plugins/plugin_list_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/user_agent.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/webkit_glue.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
10 years, 1 month ago (2010-11-13 21:11:34 UTC) #1
brettw
LGTM http://codereview.chromium.org/4974001/diff/2001/net/http/http_cache_unittest.cc File net/http/http_cache_unittest.cc (right): http://codereview.chromium.org/4974001/diff/2001/net/http/http_cache_unittest.cc#newcode907 net/http/http_cache_unittest.cc:907: for (int block_start = start; block_start < end; ...
10 years, 1 month ago (2010-11-15 00:09:23 UTC) #2
tfarina
10 years, 1 month ago (2010-11-15 01:21:24 UTC) #3
http://codereview.chromium.org/4974001/diff/2001/net/http/http_cache_unittest.cc
File net/http/http_cache_unittest.cc (right):

http://codereview.chromium.org/4974001/diff/2001/net/http/http_cache_unittest...
net/http/http_cache_unittest.cc:907: for (int block_start = start; block_start <
end; block_start += 10)
On 2010/11/15 00:09:23, brettw wrote:
> This for statement needs {} now that you made the contents >1 line.

Done.

http://codereview.chromium.org/4974001/diff/2001/net/http/http_request_header...
File net/http/http_request_headers.cc (right):

http://codereview.chromium.org/4974001/diff/2001/net/http/http_request_header...
net/http/http_request_headers.cc:163: if (!it->value.empty())
On 2010/11/15 00:09:23, brettw wrote:
> also {} on both the if (because it's >1 line) and the else (because all the
arms
> of an if-else must match with the {} usage).

Done.

Powered by Google App Engine
This is Rietveld 408576698