Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9101)

Unified Diff: chrome/test/startup/startup_test.cc

Issue 4974001: base: Get rid of 'using' declaration of StringAppendF. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/startup/shutdown_test.cc ('k') | chrome/test/tab_switching/tab_switching_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/startup/startup_test.cc
diff --git a/chrome/test/startup/startup_test.cc b/chrome/test/startup/startup_test.cc
index df381ab60bac7e8726c86d7cfa22163d32dd99f0..1b36dcb258bd7eba060bcfc6fb4790abc28cafe6 100644
--- a/chrome/test/startup/startup_test.cc
+++ b/chrome/test/startup/startup_test.cc
@@ -202,8 +202,11 @@ class StartupTest : public UIPerfTest {
}
std::string times;
- for (int i = 0; i < numCycles; ++i)
- StringAppendF(&times, "%.2f,", timings[i].end_to_end.InMillisecondsF());
+ for (int i = 0; i < numCycles; ++i) {
+ base::StringAppendF(&times,
+ "%.2f,",
+ timings[i].end_to_end.InMillisecondsF());
+ }
PrintResultList(graph, "", trace, times, "ms", important);
if (num_tabs > 0) {
@@ -213,13 +216,13 @@ class StartupTest : public UIPerfTest {
times.clear();
name = name_base + "-start";
for (int i = 0; i < numCycles; ++i)
- StringAppendF(&times, "%.2f,", timings[i].first_start_ms);
+ base::StringAppendF(&times, "%.2f,", timings[i].first_start_ms);
PrintResultList(graph, "", name.c_str(), times, "ms", important);
times.clear();
name = name_base + "-first";
for (int i = 0; i < numCycles; ++i)
- StringAppendF(&times, "%.2f,", timings[i].first_stop_ms);
+ base::StringAppendF(&times, "%.2f,", timings[i].first_stop_ms);
PrintResultList(graph, "", name.c_str(), times, "ms", important);
if (nth_timed_tab > 0) {
@@ -227,7 +230,7 @@ class StartupTest : public UIPerfTest {
times.clear();
name = name_base + "-" + base::IntToString(nth_timed_tab);
for (int i = 0; i < numCycles; ++i)
- StringAppendF(&times, "%.2f,", timings[i].nth_tab_stop_ms);
+ base::StringAppendF(&times, "%.2f,", timings[i].nth_tab_stop_ms);
PrintResultList(graph, "", name.c_str(), times, "ms", important);
}
@@ -236,7 +239,7 @@ class StartupTest : public UIPerfTest {
times.clear();
name = name_base + "-all";
for (int i = 0; i < numCycles; ++i)
- StringAppendF(&times, "%.2f,", timings[i].last_stop_ms);
+ base::StringAppendF(&times, "%.2f,", timings[i].last_stop_ms);
PrintResultList(graph, "", name.c_str(), times, "ms", important);
}
}
« no previous file with comments | « chrome/test/startup/shutdown_test.cc ('k') | chrome/test/tab_switching/tab_switching_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698