chrome/browser/crash_handler_host_linux.cc - Issue 4974001: base: Get rid of 'using' declaration of StringAppendF.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/crash_handler_host_linux.cc

Issue 4974001: base: Get rid of 'using' declaration of StringAppendF. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/crash_handler_host_linux.cc

diff --git a/chrome/browser/crash_handler_host_linux.cc b/chrome/browser/crash_handler_host_linux.cc

index 7c0c11b2c7e63cde08809b3c0f944540df5be6d8..a941cdd7a9d92607b92fe8c7289c9cffc42052fb 100644

--- a/chrome/browser/crash_handler_host_linux.cc

+++ b/chrome/browser/crash_handler_host_linux.cc

@@ -256,8 +256,8 @@ void CrashHandlerHostLinux::OnFileCanReadWithoutBlocking(int fd) {

// /proc/[pid]/syscall is formatted as follows:

// syscall_number arg1 ... arg6 sp pc

// but we just check syscall_number through arg3.

- StringAppendF(&expected_syscall_data, "%d 0x%x %p 0x1 ",

- SYS_read, tid_fd, tid_buf_addr);

+ base::StringAppendF(&expected_syscall_data, "%d 0x%x %p 0x1 ",

+ SYS_read, tid_fd, tid_buf_addr);

pid_t crashing_tid =

base::FindThreadIDWithSyscall(crashing_pid, expected_syscall_data);

if (crashing_tid == -1) {

« no previous file with comments | « base/stringprintf.h ('k') | chrome/browser/history/text_database.cc » ('j') | no next file with comments »