Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1946)

Unified Diff: chrome/browser/net/url_info.cc

Issue 4974001: base: Get rid of 'using' declaration of StringAppendF. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/predictor.cc ('k') | chrome/browser/ui/views/select_file_dialog.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/url_info.cc
diff --git a/chrome/browser/net/url_info.cc b/chrome/browser/net/url_info.cc
index 505425a752a4e66fcace2caf47df62934e61d46b..8418b12778a112f890907ed56c7c566d3fee3bb8 100644
--- a/chrome/browser/net/url_info.cc
+++ b/chrome/browser/net/url_info.cc
@@ -251,10 +251,10 @@ static std::string HoursMinutesSeconds(int seconds) {
int print_minutes = minutes % 60;
int print_hours = minutes/60;
if (print_hours)
- StringAppendF(&result, "%.2d:", print_hours);
+ base::StringAppendF(&result, "%.2d:", print_hours);
if (print_hours || print_minutes)
- StringAppendF(&result, "%2.2d:", print_minutes);
- StringAppendF(&result, "%2.2d", print_seconds);
+ base::StringAppendF(&result, "%2.2d:", print_minutes);
+ base::StringAppendF(&result, "%2.2d", print_seconds);
return result;
}
@@ -266,8 +266,8 @@ void UrlInfo::GetHtmlTable(const UrlInfoTable host_infos,
if (0 == host_infos.size())
return;
output->append(description);
- StringAppendF(output, "%" PRIuS " %s", host_infos.size(),
- (1 == host_infos.size()) ? "hostname" : "hostnames");
+ base::StringAppendF(output, "%" PRIuS " %s", host_infos.size(),
+ (1 == host_infos.size()) ? "hostname" : "hostnames");
if (brief) {
output->append("<br><br>");
@@ -291,18 +291,21 @@ void UrlInfo::GetHtmlTable(const UrlInfoTable host_infos,
for (UrlInfoTable::const_iterator it(host_infos.begin());
it != host_infos.end(); it++) {
queue.sample((it->queue_duration_.InMilliseconds()));
- StringAppendF(output, row_format,
- RemoveJs(it->url_.spec()).c_str(),
- HoursMinutesSeconds(when.sample(
- (current_time - it->time_).InSeconds())).c_str(),
- it->GetAsciiMotivation().c_str());
+ base::StringAppendF(
+ output,
+ row_format,
+ RemoveJs(it->url_.spec()).c_str(),
+ HoursMinutesSeconds(when.sample(
+ (current_time - it->time_).InSeconds())).c_str(),
+ it->GetAsciiMotivation().c_str());
}
output->append("</table>");
#ifndef NDEBUG
- StringAppendF(output,
- "Prefetch Queue Durations: min=%d, avg=%d, max=%d<br><br>",
- queue.minimum(), queue.average(), queue.maximum());
+ base::StringAppendF(
+ output,
+ "Prefetch Queue Durations: min=%d, avg=%d, max=%d<br><br>",
+ queue.minimum(), queue.average(), queue.maximum());
#endif
output->append("<br>");
« no previous file with comments | « chrome/browser/net/predictor.cc ('k') | chrome/browser/ui/views/select_file_dialog.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698