Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3649)

Unified Diff: chrome/browser/net/predictor.cc

Issue 4974001: base: Get rid of 'using' declaration of StringAppendF. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/metrics_log_unittest.cc ('k') | chrome/browser/net/url_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/predictor.cc
diff --git a/chrome/browser/net/predictor.cc b/chrome/browser/net/predictor.cc
index fd55d2f97fbbe1ca0dd36488e347bb938a4920fa..2c8ce5f8f8c9e1b7c903b63c5a4560846d8ef327 100644
--- a/chrome/browser/net/predictor.cc
+++ b/chrome/browser/net/predictor.cc
@@ -361,14 +361,16 @@ void Predictor::GetHtmlReferrerLists(std::string* output) {
for (Referrer::iterator future_url = referrer->begin();
future_url != referrer->end(); ++future_url) {
output->append("<tr align=right>");
- if (first_set_of_futures)
- StringAppendF(output, "<td rowspan=%d>%s</td><td rowspan=%d>%d</td>",
- static_cast<int>(referrer->size()),
- it->spec().c_str(),
- static_cast<int>(referrer->size()),
- static_cast<int>(referrer->use_count()));
+ if (first_set_of_futures) {
+ base::StringAppendF(output,
+ "<td rowspan=%d>%s</td><td rowspan=%d>%d</td>",
+ static_cast<int>(referrer->size()),
+ it->spec().c_str(),
+ static_cast<int>(referrer->size()),
+ static_cast<int>(referrer->use_count()));
+ }
first_set_of_futures = false;
- StringAppendF(output,
+ base::StringAppendF(output,
"<td>%d</td><td>%d</td><td>%d</td><td>%2.3f</td><td>%s</td></tr>",
static_cast<int>(future_url->second.navigation_count()),
static_cast<int>(future_url->second.preconnection_count()),
« no previous file with comments | « chrome/browser/metrics/metrics_log_unittest.cc ('k') | chrome/browser/net/url_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698