Issue 399016: Fix race conditions where an object's constructor uses PostTask on itself. T...

Issue 399016: Fix race conditions where an object's constructor uses PostTask on itself. T... (Closed)

Created:
11 years, 1 month ago by jam

Modified:
9 years, 7 months ago

Reviewers:
jamesr, Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix race conditions where an object's constructor uses PostTask on itself. This isn't safe since the posted task can execute before the constructor returns, leading to destruction of the object. BUG=27944 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32213

Patch Set 1 : '' #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 2

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -46 lines)			Patch
M	base/task.h	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/crx_installer.h	View	2 3	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/crx_installer.cc	View	2 3	1 chunk	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/privacy_blacklist/blacklist_manager.h	View	2	1 chunk	+2 lines, -1 line	0 comments	Download
MM	chrome/browser/privacy_blacklist/blacklist_manager.cc	View	2	1 chunk	+11 lines, -6 lines	0 comments	Download
M	chrome/browser/privacy_blacklist/blacklist_manager_browsertest.cc	View	2	1 chunk	+2 lines, -2 lines	0 comments	Download
MM	chrome/browser/privacy_blacklist/blacklist_manager_unittest.cc	View	2	6 chunks	+12 lines, -11 lines	0 comments	Download
M	chrome/browser/profile.cc	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/strict_transport_security_persister.h	View	1 2	2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/strict_transport_security_persister.cc	View	1 2	2 chunks	+13 lines, -11 lines	0 comments	Download
M	views/widget/aero_tooltip_manager.h	View	1 2	1 chunk	+2 lines, -1 line	2 comments	Download
M	views/widget/aero_tooltip_manager.cc	View	1 2	2 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jamesr

LGTM. Good catch! http://codereview.chromium.org/399016/diff/4014/4015 File views/widget/aero_tooltip_manager.h (right): http://codereview.chromium.org/399016/diff/4014/4015#newcode43 Line 43: InitialTimer(AeroTooltipManager* manager); This needs to ...

11 years, 1 month ago (2009-11-17 21:00:07 UTC) #2

jam

11 years, 1 month ago (2009-11-17 21:03:21 UTC) #3

http://codereview.chromium.org/399016/diff/4014/4015
File views/widget/aero_tooltip_manager.h (right):

http://codereview.chromium.org/399016/diff/4014/4015#newcode43
Line 43: InitialTimer(AeroTooltipManager* manager);
On 2009/11/17 21:00:07, jamesr wrote:
> This needs to be marked explicit

Done.

Expand Messages | Collapse Messages