Fix race conditions where an object's constructor uses PostTask on itself. T...

chrome/browser/extensions/crx_installer.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/crx_installer.h"
 
 #include "app/l10n_util.h"
 #include "base/file_util.h"
 #include "base/scoped_temp_dir.h"
 #include "base/string_util.h"
@@ skipping 27 matching lines @@
                          ExtensionInstallUI* client) {
   // Note: We don't keep a reference because this object manages its own
   // lifetime.
   CrxInstaller* installer = new CrxInstaller(crx_path, install_directory,
                                              delete_source, frontend,
                                              client);
   installer->install_source_ = install_source;
   installer->expected_id_ = expected_id;
   installer->allow_privilege_increase_ = allow_privilege_increase;
 
-  installer->unpacker_ = new SandboxedExtensionUnpacker(
-      installer->source_file_, g_browser_process->resource_dispatcher_host(),
-      installer);
+  scoped_refptr<SandboxedExtensionUnpacker> unpacker(
+      new SandboxedExtensionUnpacker(
+          installer->source_file_,
+          g_browser_process->resource_dispatcher_host(),
+          installer));
 
   ChromeThread::PostTask(
       ChromeThread::FILE, FROM_HERE,
-      NewRunnableMethod(installer->unpacker_, &SandboxedExtensionUnpacker::Start));
+      NewRunnableMethod(
+          unpacker.get(), &SandboxedExtensionUnpacker::Start));
 }
 
 void CrxInstaller::InstallUserScript(const FilePath& source_file,
                                      const GURL& original_url,
                                      const FilePath& install_directory,
                                      bool delete_source,
                                      ExtensionsService* frontend,
                                      ExtensionInstallUI* client) {
   CrxInstaller* installer = new CrxInstaller(source_file, install_directory,
                                              delete_source, frontend, client);
@@ skipping 277 matching lines @@
     client_->OnInstallSuccess(extension_.get());
 
   // Tell the frontend about the installation and hand off ownership of
   // extension_ to it.
   frontend_->OnExtensionInstalled(extension_.release(),
                                   allow_privilege_increase_);
 
   // We're done. We don't post any more tasks to ourselves so we are deleted
   // soon.
 }