Fix race conditions where an object's constructor uses PostTask on itself. T...

chrome/browser/privacy_blacklist/blacklist_manager.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/privacy_blacklist/blacklist_manager.h"
 
 #include "base/message_loop.h"
 #include "base/string_util.h"
 #include "base/task.h"
 #include "base/thread.h"
 #include "chrome/browser/privacy_blacklist/blacklist.h"
 #include "chrome/browser/privacy_blacklist/blacklist_io.h"
 #include "chrome/browser/profile.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/notification_service.h"
 #include "chrome/common/notification_source.h"
 #include "chrome/common/notification_type.h"
 
 BlacklistPathProvider::~BlacklistPathProvider() {
 }
 
-BlacklistManager::BlacklistManager(Profile* profile,
-                                   BlacklistPathProvider* path_provider)
+BlacklistManager::BlacklistManager()
     : first_read_finished_(false),
-      profile_(profile),
-      compiled_blacklist_path_(
-        profile->GetPath().Append(chrome::kPrivacyBlacklistFileName)),
-      path_provider_(path_provider) {
+      profile_(NULL),
+      path_provider_(NULL) {
   DCHECK(ChromeThread::CurrentlyOn(ChromeThread::UI));
+}
+
+void BlacklistManager::Initialize(Profile* profile,
+                                  BlacklistPathProvider* path_provider) {
+  profile_ = profile;
+  compiled_blacklist_path_ =
+      profile->GetPath().Append(chrome::kPrivacyBlacklistFileName);
+  path_provider_ = path_provider;
 
   registrar_.Add(this,
                  NotificationType::EXTENSION_LOADED,
                  Source<Profile>(profile));
   registrar_.Add(this,
                  NotificationType::EXTENSION_UNLOADED,
                  Source<Profile>(profile));
   ReadBlacklist();
 }
 
@@ skipping 119 matching lines @@
     return;
   }
   first_read_finished_ = true;
   compiled_blacklist_.reset(blacklist);
 
   NotificationService::current()->Notify(
       NotificationType::BLACKLIST_MANAGER_BLACKLIST_READ_FINISHED,
       Source<Profile>(profile_),
       Details<Blacklist>(blacklist));
 }