Fix race conditions where an object's constructor uses PostTask on itself. T...

chrome/browser/strict_transport_security_persister.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // StrictTransportSecurityState maintains an in memory database containing the
 // list of hosts that currently have strict transport security enabled. This
 // singleton object deals with writing that data out to disk as needed and
 // loading it at startup.
 
 // At startup we need to load the strict transport security state from the
@@ skipping 24 matching lines @@
 
 #include "base/file_path.h"
 #include "base/lock.h"
 #include "base/ref_counted.h"
 #include "net/base/strict_transport_security_state.h"
 
 class StrictTransportSecurityPersister
     : public base::RefCountedThreadSafe<StrictTransportSecurityPersister>,
       public net::StrictTransportSecurityState::Delegate {
  public:
-  StrictTransportSecurityPersister(net::StrictTransportSecurityState* state,
-                                   const FilePath& profile_path);
+  StrictTransportSecurityPersister();
+  void Initialize(net::StrictTransportSecurityState* state,
+                  const FilePath& profile_path);
 
   // Called by the StrictTransportSecurityState when it changes its state.
   virtual void StateIsDirty(net::StrictTransportSecurityState*);
 
  private:
   friend class base::RefCountedThreadSafe<StrictTransportSecurityPersister>;
 
   ~StrictTransportSecurityPersister();
 
   // a Task callback for when the state needs to be written out.
   void SerialiseState();
 
   // a Task callback for when the state needs to be loaded from disk at startup.
   void LoadState();
 
   Lock lock_;  // protects all the members
 
   // true when the state object has signaled that we're dirty and we haven't
   // serialised the state yet.
   bool state_is_dirty_;
 
   scoped_refptr<net::StrictTransportSecurityState>
       strict_transport_security_state_;
   // The path to the file in which we store the serialised state.
-  const FilePath state_file_;
+  FilePath state_file_;
 };
 
 #endif  // CHROME_BROWSER_STRICT_TRANSPORT_SECURITY_PERSISTER_H_