Fix race conditions where an object's constructor uses PostTask on itself. T...

views/widget/aero_tooltip_manager.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "views/widget/aero_tooltip_manager.h"
 
 #include <windows.h>
 #include <commctrl.h>
 #include <shlobj.h>
 
@@ skipping 29 matching lines @@
       UpdateTooltip(mouse_pos.x(), mouse_pos.y());
     }
 
     // Delay opening of the tooltip just in case the user moves their
     // mouse to another control. We defer this from Init because we get
     // zero if we query it too soon.
     if (!initial_delay_) {
       initial_delay_ = static_cast<int>(
           ::SendMessage(tooltip_hwnd_, TTM_GETDELAYTIME, TTDT_INITIAL, 0));
     }
-    initial_timer_ = new InitialTimer(this, initial_delay_);
+    initial_timer_ = new InitialTimer(this);
+    initial_timer_->Start(initial_delay_);
   } else {
     // Hide the tooltip and cancel any timers.
     ::SendMessage(tooltip_hwnd_, TTM_POP, 0, 0);
     ::SendMessage(tooltip_hwnd_, TTM_TRACKACTIVATE, false, (LPARAM)&toolinfo_);
     return;
   }
 }
 
 void AeroTooltipManager::OnMouseLeave() {
   last_mouse_x_ = last_mouse_y_ = -1;
@@ skipping 40 matching lines @@
   if (!tooltip_showing_) {
     ::SendMessage(tooltip_hwnd_, TTM_POPUP, 0, 0);
     ::SendMessage(tooltip_hwnd_, TTM_TRACKPOSITION, 0, MAKELPARAM(pt.x, pt.y));
     ::SendMessage(tooltip_hwnd_, TTM_TRACKACTIVATE, true, (LPARAM)&toolinfo_);
   }
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // AeroTooltipManager::InitialTimer
 
-AeroTooltipManager::InitialTimer::InitialTimer(AeroTooltipManager* manager,
-                                               int time) : manager_(manager) {
+AeroTooltipManager::InitialTimer::InitialTimer(AeroTooltipManager* manager)
+    : manager_(manager) {
+}
+
+void AeroTooltipManager::InitialTimer::Start(int time) {
   MessageLoop::current()->PostDelayedTask(FROM_HERE, NewRunnableMethod(
       this, &InitialTimer::Execute), time);
 }
 
 void AeroTooltipManager::InitialTimer::Disown() {
   manager_ = NULL;
 }
 
 void AeroTooltipManager::InitialTimer::Execute() {
   if (manager_)
     manager_->OnTimer();
 }
 
 }  // namespace views