Linux: enable building with a local version of libssl.

Linux: enable building with a local version of libssl.

[agl, 2009-11-13 02:20:41]

This CL is too large to Reitvelt: some of the files maybe missing but I think
the non-adds are at the top and got uploaded ok.

[agl, 2009-11-13 23:56:08]

ping.

[wtc, 2009-11-14 00:43:11]

LGTM.  Thanks!

We should build the code as a .so (libssl3.so) in the
future.  That requires installer package work though.

Should we put this under net/third_party instead of the
top-level third_party directory because libssl3.so is only
used by net?

What does "bodge" mean?

third_party/nss/README.google:

Nit: we may want to use a release tag such as
NSS_3_12_5_BETA2 instead of a snapshot.

third_party/nss/nss.gyp:

In the 'sources!' list for linux, you can also exclude
        'ssl/os2_err.c',
        'ssl/os2_err.h',

third_party/nss/ssl/bodge/secure_memcmp.c:

You can mention NSS_SecureMemcmp was added in NSS 3.12.5.

How did you deal with the declaration of NSS_SecureMemcmp?

There is a utilrename.h header that we should get from
mozilla/security/nss/lib/util.  Add USE_UTIL_DIRECTLY to
the defines to benefit from it.

[wtc, 2009-11-16 22:45:58]

Re: NSS_SecureMemcmp

Could you find out why we're not getting the "implicit declaration"
warning from GCC?  We added the declaration of NSS_SecureMemcmp to
<secport.h> in NSS 3.12.5, which hasn't been released yet.

Re: utilrename.h

Sorry, I was confused.  utilrename.h is a public NSS header, so
we get it from the system NSS include directory.  We should not
add utilrename.h to our ssl/bodge directory.  We just need to
add USE_UTIL_DIRECTLY to the 'defines' variable in
net/third_party/nss/nss.gyp.