Fix some style issues in the ARM code....

Fix some style issues in the ARM code.
Also move a function into the macro assembler.
Fix some *& placement errors that had accumulated.

Committed: http://code.google.com/p/v8/source/detail?r=3293

[Mads Ager (chromium), 2009-11-12 13:25:24]

You must need changes in all the other platform files as well?

http://codereview.chromium.org/385069/diff/1/7
File src/arm/assembler-arm.h (right):

http://codereview.chromium.org/385069/diff/1/7#newcode444
Line 444: class Scope BASE_EMBEDDED {
Could you add the

// Enable a specified feature within a scope.

comment.

http://codereview.chromium.org/385069/diff/1/10
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/385069/diff/1/10#newcode5110
Line 5110: if      (Token::MUL == operation) __ fmuld(d5, d6, d7);
Please remove extra spacing.

[Erik Corry, 2009-11-12 13:42:37]

I moved the call to OS::ArmCpuHasFeature inside an ifdef so it shouldn't be
missing on other platforms when using the simulator.  If anyone ports V8 to a
non-Linux ARM platform it will be missing, but that will be a useful piece of
information to the porter.

http://codereview.chromium.org/385069/diff/1/7
File src/arm/assembler-arm.h (right):

http://codereview.chromium.org/385069/diff/1/7#newcode444
Line 444: class Scope BASE_EMBEDDED {
On 2009/11/12 13:25:24, Mads Ager wrote:
> Could you add the
> 
> // Enable a specified feature within a scope.
> 
> comment.

Done.

http://codereview.chromium.org/385069/diff/1/10
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/385069/diff/1/10#newcode5110
Line 5110: if      (Token::MUL == operation) __ fmuld(d5, d6, d7);
On 2009/11/12 13:25:24, Mads Ager wrote:
> Please remove extra spacing.

I also added {}

[Mads Ager (chromium), 2009-11-12 13:47:34]

LGTM