Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: src/arm/disasm-arm.cc

Issue 385069: Fix some style issues in the ARM code.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/arm/disasm-arm.cc
===================================================================
--- src/arm/disasm-arm.cc (revision 3292)
+++ src/arm/disasm-arm.cc (working copy)
@@ -336,6 +336,7 @@
return -1;
}
+
// Handle all VFP register based formatting in this function to reduce the
// complexity of FormatOption.
int Decoder::FormatVFPRegister(Instr* instr, const char* format) {
@@ -362,14 +363,13 @@
return -1;
}
+
int Decoder::FormatVFPinstruction(Instr* instr, const char* format) {
Print(format);
return 0;
}
-
-
// FormatOption takes a formatting string and interprets it based on
// the current instructions. The format string points to the first
// character of the option string (the option escape has already been
@@ -897,10 +897,9 @@
// void Decoder::DecodeTypeVFP(Instr* instr)
-// Implements the following
-// VFP instructions
-// fmsr :Sn = Rt
-// fmrs :Rt = Sn
+// Implements the following VFP instructions:
+// fmsr: Sn = Rt
+// fmrs: Rt = Sn
// fsitod: Dd = Sm
// ftosid: Sd = Dm
// Dd = faddd(Dn, Dm)
@@ -951,9 +950,9 @@
if (instr->Bits(15, 12) == 0xF)
Format(instr, "vmrs'cond APSR, FPSCR");
else
- Unknown(instr); // not used by V8
+ Unknown(instr); // Not used by V8.
} else {
- Unknown(instr); // not used by V8
+ Unknown(instr); // Not used by V8.
}
} else if (instr->Bit(21) == 1) {
if ((instr->Bit(20) == 0x1) &&
@@ -975,7 +974,7 @@
(instr->Bit(4) == 0)) {
Format(instr, "vmul.f64'cond 'Dd, 'Dn, 'Dm");
} else {
- Unknown(instr); // not used by V8
+ Unknown(instr); // Not used by V8.
}
} else {
if ((instr->Bit(20) == 0x0) &&
@@ -991,21 +990,20 @@
(instr->Bits(3, 0) == 0x0)) {
Format(instr, "vmov'cond 'rt, 'Sn");
} else {
- Unknown(instr); // not used by V8
+ Unknown(instr); // Not used by V8.
}
}
}
-
-// Decode Type 6 coprocessor instructions
+// Decode Type 6 coprocessor instructions.
// Dm = fmdrr(Rt, Rt2)
// <Rt, Rt2> = fmrrd(Dm)
void Decoder::DecodeType6CoprocessorIns(Instr* instr) {
ASSERT((instr->TypeField() == 6));
if (instr->Bit(23) == 1) {
- Unknown(instr); // not used by V8
+ Unknown(instr); // Not used by V8.
} else if (instr->Bit(22) == 1) {
if ((instr->Bits(27, 24) == 0xC) &&
(instr->Bit(22) == 1) &&
@@ -1018,12 +1016,12 @@
Format(instr, "vmov'cond 'rt, 'rn, 'Dm");
}
} else {
- Unknown(instr); // not used by V8
+ Unknown(instr); // Not used by V8.
}
} else if (instr->Bit(21) == 1) {
- Unknown(instr); // not used by V8
+ Unknown(instr); // Not used by V8.
} else {
- Unknown(instr); // not used by V8
+ Unknown(instr); // Not used by V8.
}
}

Powered by Google App Engine
This is Rietveld 408576698