Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3814013: FBTF: Monster ctor patch after changing heuristics in clang plugin. (Closed)

Created:
10 years, 2 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews, vrk (LEFT CHROMIUM), stuartmorgan+watch_chromium.org, ncarter (slow), fbarchard, Alpha Left Google, Erik does not do reviews, jam, darin-cc_chromium.org, garykac, tim (not reviewing), ben+cc_chromium.org, Raghu Simha, cbentzel+watch_chromium.org, pam+watch_chromium.org, awong, scherkus (not reviewing), michaeln, Sergey Ulanov, idana, Aaron Boodman, dmac, Paweł Hajdan Jr.
Visibility:
Public.

Description

FBTF: Monster ctor patch after changing heuristics in clang plugin. (Only 916k this time off Debug Linux .a files) BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62967

Patch Set 1 #

Patch Set 2 : Missing file fail #

Patch Set 3 : More add file fail #

Unified diffs Side-by-side diffs Delta from patch set Stats (+498 lines, -182 lines) Patch
M app/multi_animation.h View 1 chunk +1 line, -0 lines 0 comments Download
M app/multi_animation.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/appcache/appcache_dispatcher_host.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/appcache/appcache_dispatcher_host.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/debugger/devtools_netlog_observer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/file_system/file_system_host_context.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/file_system/file_system_host_context.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/engine/net/syncapi_server_connection_manager.h View 2 chunks +6 lines, -13 lines 0 comments Download
M chrome/browser/sync/engine/net/syncapi_server_connection_manager.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M chrome/browser/sync/engine/syncapi.h View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/sync/engine/syncapi.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_message_bundle.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_message_bundle.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M media/base/callback.h View 2 chunks +5 lines, -11 lines 0 comments Download
A media/base/callback.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M media/media.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M net/disk_cache/disk_format.h View 4 chunks +4 lines, -10 lines 0 comments Download
A net/disk_cache/disk_format.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M net/disk_cache/file.h View 1 chunk +2 lines, -2 lines 0 comments Download
A net/disk_cache/file.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M net/disk_cache/mem_backend_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/mem_backend_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/disk_cache/sparse_control.h View 1 chunk +1 line, -6 lines 0 comments Download
M net/disk_cache/sparse_control.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M net/ftp/ftp_ctrl_response_buffer.h View 3 chunks +6 lines, -13 lines 0 comments Download
M net/ftp/ftp_ctrl_response_buffer.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_hprc.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_hprc.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_ls.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_ls.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_mlsd.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_mlsd.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_netware.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_netware.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_vms.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_vms.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_windows.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_windows.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/ftp/ftp_network_session.h View 2 chunks +2 lines, -3 lines 0 comments Download
A net/ftp/ftp_network_session.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M net/http/http_cache.h View 1 chunk +3 lines, -5 lines 0 comments Download
M net/http/http_cache.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M net/http/http_net_log_params.h View 2 chunks +11 lines, -41 lines 0 comments Download
A net/http/http_net_log_params.cc View 1 chunk +59 lines, -0 lines 0 comments Download
M net/http/http_proxy_client_socket.cc View 1 chunk +1 line, -0 lines 0 comments Download
net/http/partial_data.h View 1 chunk +1 line, -3 lines 0 comments Download
M net/http/partial_data.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M net/http/url_security_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
net/http/url_security_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/net.gyp View 4 chunks +4 lines, -0 lines 0 comments Download
M net/proxy/proxy_resolver_script_data.h View 1 chunk +4 lines, -5 lines 0 comments Download
M net/proxy/proxy_resolver_script_data.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request_job_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request_job_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/url_request/url_request_job_metrics.h View 1 chunk +2 lines, -5 lines 0 comments Download
M net/url_request/url_request_job_metrics.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M net/url_request/view_cache_helper.h View 1 chunk +1 line, -8 lines 0 comments Download
M net/url_request/view_cache_helper.cc View 1 chunk +16 lines, -0 lines 0 comments Download
remoting/base/encoder_zlib.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/encoder_zlib.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/base/tracer.h View 2 chunks +9 lines, -26 lines 0 comments Download
M remoting/base/tracer.cc View 2 chunks +41 lines, -0 lines 0 comments Download
M remoting/host/client_connection.h View 1 chunk +1 line, -1 line 0 comments Download
remoting/host/client_connection.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/host/differ.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/differ.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/host/in_memory_host_config.h View 2 chunks +1 line, -1 line 0 comments Download
M remoting/host/in_memory_host_config.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/host/json_host_config.h View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/json_host_config.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/protocol/messages_decoder.h View 2 chunks +6 lines, -5 lines 0 comments Download
remoting/protocol/messages_decoder.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M remoting/protocol/stream_reader.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/media/media_resource_loader_bridge_factory.h View 2 chunks +2 lines, -3 lines 0 comments Download
M webkit/glue/media/media_resource_loader_bridge_factory.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M webkit/glue/plugins/gtk_plugin_container_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/glue/plugins/gtk_plugin_container_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/plugins/pepper_string.h View 1 chunk +2 lines, -2 lines 0 comments Download
A webkit/glue/plugins/pepper_string.cc View 1 chunk +13 lines, -0 lines 0 comments Download
webkit/glue/plugins/pepper_webplugin_impl.h View 1 chunk +1 line, -6 lines 0 comments Download
M webkit/glue/plugins/pepper_webplugin_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 2 chunks +4 lines, -2 lines 0 comments Download
M webkit/glue/webvideoframe_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webvideoframe_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
Apologies that this CL grew so large before I realized it.
10 years, 2 months ago (2010-10-18 19:06:14 UTC) #1
James Hawkins
10 years, 2 months ago (2010-10-18 19:57:24 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698