Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: media/base/callback.h

Issue 3814013: FBTF: Monster ctor patch after changing heuristics in clang plugin. (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: More add file fail Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension_message_bundle.cc ('k') | media/base/callback.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/callback.h
diff --git a/media/base/callback.h b/media/base/callback.h
index cefcae925e03411b1433ec1b058c50cc81585e68..2273ace703e6bf6b0625424c1006fbb0e0d62e73 100644
--- a/media/base/callback.h
+++ b/media/base/callback.h
@@ -34,11 +34,7 @@ class AutoTaskRunner {
: task_(task) {
}
- ~AutoTaskRunner() {
- if (task_.get()) {
- task_->Run();
- }
- }
+ ~AutoTaskRunner();
Task* release() { return task_.release(); }
@@ -71,16 +67,14 @@ class AutoCallbackRunner {
class TaskToCallbackAdapter : public Callback0::Type {
public:
- static Callback0::Type* NewCallback(Task* task) {
- return new TaskToCallbackAdapter(task);
- }
+ static Callback0::Type* NewCallback(Task* task);
- virtual ~TaskToCallbackAdapter() {}
+ virtual ~TaskToCallbackAdapter();
- virtual void RunWithParams(const Tuple0& params) { task_->Run(); }
+ virtual void RunWithParams(const Tuple0& params);
private:
- TaskToCallbackAdapter(Task* task) : task_(task) {}
+ TaskToCallbackAdapter(Task* task);
scoped_ptr<Task> task_;
« no previous file with comments | « chrome/common/extensions/extension_message_bundle.cc ('k') | media/base/callback.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698