Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: net/http/http_net_log_params.h

Issue 3814013: FBTF: Monster ctor patch after changing heuristics in clang plugin. (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: More add file fail Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_cache.cc ('k') | net/http/http_net_log_params.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_net_log_params.h
diff --git a/net/http/http_net_log_params.h b/net/http/http_net_log_params.h
index 4331a0f2c1d659e645ad63ba6bb9064ef0f01ed2..403b6a79f47fa82fd9a76c1420d82fe7de7783be 100644
--- a/net/http/http_net_log_params.h
+++ b/net/http/http_net_log_params.h
@@ -10,43 +10,28 @@
#include "base/basictypes.h"
#include "base/ref_counted.h"
-#include "base/stringprintf.h"
-#include "base/values.h"
#include "net/base/net_log.h"
#include "net/http/http_request_headers.h"
-#include "net/http/http_response_headers.h"
+
+class Value;
namespace net {
+class HttpResponseHeaders;
+
class NetLogHttpRequestParameter : public NetLog::EventParameters {
public:
NetLogHttpRequestParameter(const std::string& line,
- const HttpRequestHeaders& headers)
- : line_(line) {
- headers_.CopyFrom(headers);
- }
+ const HttpRequestHeaders& headers);
- Value* ToValue() const {
- DictionaryValue* dict = new DictionaryValue();
- dict->SetString("line", line_);
- ListValue* headers = new ListValue();
- HttpRequestHeaders::Iterator iterator(headers_);
- while (iterator.GetNext()) {
- headers->Append(
- new StringValue(base::StringPrintf("%s: %s",
- iterator.name().c_str(),
- iterator.value().c_str())));
- }
- dict->Set("headers", headers);
- return dict;
- }
+ Value* ToValue() const;
const HttpRequestHeaders& GetHeaders() const {
return headers_;
}
private:
- ~NetLogHttpRequestParameter() {}
+ virtual ~NetLogHttpRequestParameter();
const std::string line_;
HttpRequestHeaders headers_;
@@ -57,31 +42,16 @@ class NetLogHttpRequestParameter : public NetLog::EventParameters {
class NetLogHttpResponseParameter : public NetLog::EventParameters {
public:
explicit NetLogHttpResponseParameter(
- const scoped_refptr<HttpResponseHeaders>& headers)
- : headers_(headers) {}
-
- Value* ToValue() const {
- DictionaryValue* dict = new DictionaryValue();
- ListValue* headers = new ListValue();
- headers->Append(new StringValue(headers_->GetStatusLine()));
- void* iterator = NULL;
- std::string name;
- std::string value;
- while (headers_->EnumerateHeaderLines(&iterator, &name, &value)) {
- headers->Append(
- new StringValue(base::StringPrintf("%s: %s", name.c_str(),
- value.c_str())));
- }
- dict->Set("headers", headers);
- return dict;
- }
+ const scoped_refptr<HttpResponseHeaders>& headers);
+
+ Value* ToValue() const;
const HttpResponseHeaders& GetHeaders() const {
return *headers_;
}
private:
- ~NetLogHttpResponseParameter() {}
+ virtual ~NetLogHttpResponseParameter();
const scoped_refptr<HttpResponseHeaders> headers_;
« no previous file with comments | « net/http/http_cache.cc ('k') | net/http/http_net_log_params.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698