Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: net/ftp/ftp_ctrl_response_buffer.h

Issue 3814013: FBTF: Monster ctor patch after changing heuristics in clang plugin. (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: More add file fail Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/disk_cache/sparse_control.cc ('k') | net/ftp/ftp_ctrl_response_buffer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ftp/ftp_ctrl_response_buffer.h
diff --git a/net/ftp/ftp_ctrl_response_buffer.h b/net/ftp/ftp_ctrl_response_buffer.h
index b98f4947f20be1f6817bf882394ea454b5fa7c84..219a2d42ac220082eb090031336229559cdfc237 100644
--- a/net/ftp/ftp_ctrl_response_buffer.h
+++ b/net/ftp/ftp_ctrl_response_buffer.h
@@ -18,7 +18,8 @@ namespace net {
struct FtpCtrlResponse {
static const int kInvalidStatusCode;
- FtpCtrlResponse() : status_code(kInvalidStatusCode) {}
+ FtpCtrlResponse();
+ ~FtpCtrlResponse();
int status_code; // Three-digit status code.
std::vector<std::string> lines; // Response lines, without CRLFs.
@@ -26,7 +27,8 @@ struct FtpCtrlResponse {
class FtpCtrlResponseBuffer {
public:
- FtpCtrlResponseBuffer() : multiline_(false) {}
+ FtpCtrlResponseBuffer();
+ ~FtpCtrlResponseBuffer();
// Called when data is received from the control socket. Returns error code.
int ConsumeData(const char* data, int data_length);
@@ -37,20 +39,11 @@ class FtpCtrlResponseBuffer {
// Returns the next response. It is an error to call this function
// unless ResponseAvailable returns true.
- FtpCtrlResponse PopResponse() {
- FtpCtrlResponse result = responses_.front();
- responses_.pop();
- return result;
- }
+ FtpCtrlResponse PopResponse();
private:
struct ParsedLine {
- ParsedLine()
- : has_status_code(false),
- is_multiline(false),
- is_complete(false),
- status_code(FtpCtrlResponse::kInvalidStatusCode) {
- }
+ ParsedLine();
// Indicates that this line begins with a valid 3-digit status code.
bool has_status_code;
« no previous file with comments | « net/disk_cache/sparse_control.cc ('k') | net/ftp/ftp_ctrl_response_buffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698