Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1416)

Unified Diff: chrome/browser/sync/engine/net/syncapi_server_connection_manager.h

Issue 3814013: FBTF: Monster ctor patch after changing heuristics in clang plugin. (Closed) Base URL: http://git.chromium.org/git/chromium.git
Patch Set: More add file fail Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/engine/net/syncapi_server_connection_manager.h
diff --git a/chrome/browser/sync/engine/net/syncapi_server_connection_manager.h b/chrome/browser/sync/engine/net/syncapi_server_connection_manager.h
index 4108f9acb3450eeadb18e303cd0dce47b9ac5086..cdf07110bedea9209eee5ad3dbfbad4b33fdd2a3 100644
--- a/chrome/browser/sync/engine/net/syncapi_server_connection_manager.h
+++ b/chrome/browser/sync/engine/net/syncapi_server_connection_manager.h
@@ -21,11 +21,9 @@ class SyncAPIBridgedPost
: public browser_sync::ServerConnectionManager::Post {
public:
SyncAPIBridgedPost(browser_sync::ServerConnectionManager* scm,
- HttpPostProviderFactory* factory)
- : Post(scm), factory_(factory) {
- }
+ HttpPostProviderFactory* factory);
- virtual ~SyncAPIBridgedPost() { }
+ virtual ~SyncAPIBridgedPost();
virtual bool Init(const char* path,
const std::string& auth_token,
@@ -51,17 +49,12 @@ class SyncAPIServerConnectionManager
int port,
bool use_ssl,
const std::string& client_version,
- HttpPostProviderFactory* factory)
- : ServerConnectionManager(server, port, use_ssl, client_version),
- post_provider_factory_(factory) {
- DCHECK(post_provider_factory_.get());
- }
-
+ HttpPostProviderFactory* factory);
virtual ~SyncAPIServerConnectionManager();
+
protected:
- virtual Post* MakePost() {
- return new SyncAPIBridgedPost(this, post_provider_factory_.get());
- }
+ virtual Post* MakePost();
+
private:
// A factory creating concrete HttpPostProviders for use whenever we need to
// issue a POST to sync servers.

Powered by Google App Engine
This is Rietveld 408576698