Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 3655006: Fixes bugs in usage of adding a new tab with a disposition of (Closed)

Created:
10 years, 2 months ago by sky
Modified:
9 years, 7 months ago
CC:
chromium-reviews, pam+watch_chromium.org, ben+cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Fixes bugs in usage of adding a new tab with a disposition of NEW_WINDOW. Many places were leaking a Browser and preventing Chrome from shutting down. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=62408

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Fix includes #

Patch Set 4 : Fix mac build error #

Patch Set 5 : More mac fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -79 lines) Patch
M chrome/browser/cocoa/about_window_controller.mm View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/cocoa/preferences_window_controller.mm View 1 2 3 2 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/gtk/options/advanced_contents_gtk.cc View 1 2 8 chunks +16 lines, -18 lines 0 comments Download
M chrome/browser/gtk/options/content_filter_page_gtk.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/gtk/options/cookie_filter_page_gtk.cc View 2 chunks +3 lines, -6 lines 0 comments Download
A chrome/browser/show_options_url.h View 1 chunk +20 lines, -0 lines 0 comments Download
A chrome/browser/show_options_url.cc View 1 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/views/options/advanced_contents_view.cc View 1 2 4 chunks +11 lines, -15 lines 0 comments Download
M chrome/browser/views/options/cookie_filter_page_view.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/views/options/general_page_view.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/views/options/plugin_filter_page_view.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sky
10 years, 2 months ago (2010-10-12 17:18:17 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698